This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
[PRTL-2548] Fix Truncated Sample Text in Days to Birth #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anncatton
suggested changes
May 2, 2019
| paddingRight: '5px', | ||
| paddingLeft: '5px', | ||
| }} | ||
| title={`eg. ${minDisplayed}`} |
There was a problem hiding this comment.
Talked Rosi & Brandon, can we change the title text to Min value: eg. ${minDisplayed}
| paddingRight: '5px', | ||
| paddingLeft: '5px', | ||
| }} | ||
| title={`eg. ${maxDisplayed}`} |
There was a problem hiding this comment.
change title to Max value: eg. ${maxDisplayed}
anncatton
added a commit
that referenced
this pull request
Jun 19, 2019
* Part of the code. * temp * Added RecursiveToggledBox. * Completed the toggle function, and fix duplicated title. * Added the facet. * small fix. * Changed the style. * Changed the style. * Part of code. * Removed the code. * Changed the style. * Carry on. * Part of clinical facets. * Finished the userfulFacet. * Modified the code. * set toggle to false. * Completed the only show field with values functionality. * Clean up code. * Clean up. * Clean up. * clean * Add Experimental Strategy as a facet in case tab and change the style of search bar in clinical tab. * Added part of the hightlight filter. * Changed show to shown. * Changed the endpoint to graphql. * Removed row wrapper for facetHeader. * Enabled the global filter for the facet. * improved the search bar. * Alphabetize Fields in the clinical tab. (#2481) * Added blacklist for specific fields. (#2487) * Added sample type facet into case tab. (#2489) * [PRTL-2465] Make Categories "Expand All" with Sticky Header (#2492) * Added facets expanded status into redux. * Improved the state of expand status. * sticky header will not be affected by banner. * Updated code based on feedback. * Added height variable. * Changed action name. * Changed the prettier setting for trailing comma. And corrected all the trailing comma for functions. * Corrected some trailing commas. * [PRTL-2498] Move definition location on search (#2496) * Added facets expanded status into redux. * Impoved the state of expand status. * sticky header will not be affected by banner. * Updated code based on feedback. * Moved description to the middle of each facets and add tooltips for header. * Added width for tooltip. * Sent description string instead of component to tooltip of facetHeader. * Added maxWidth for tooltips. * Removed conflict. * Changed typo. * [PRTL-2505] Save state when you switch from clinical tab (#2494) * Added facets expanded status into redux. * Impoved the state of expand status. * sticky header will not be affected by banner. * Keep the old state of facetsExpanderdStatus while addAllFacets. * Added showingMore into facetsExpandedStatus. * Recover piece of code. * Added the missing excluded for demographic. * Delete RecursiveToggledFacet.js * Replaced hightlight. * PRTL-2512 fix facet label wrapping issues * Added types for clinicalAggregations; Changed font size. * [PRTL-2506] Fix table height on scroll (#2501) Fix table height on scroll * Added state to blacklist; reduced padding between header; Fixed expand all button to expand category too. (#2508) * Modified logic of expand all. * [PRTL-2518] Add "Available Variation Data" facet to Case tab (#2509) * Added available_variation_data facet in case tab. * Added filter to remove _missing elements. * PRTL-2532 test flex custom clustering for facets * PRTL-2500 add “no data” component to empty categories WIP. this component can and should be abstracted into a reusable component. * Fixed errors from eslint. * [PRTL-2522] Enhancements to Sticky Header Experience (#2512) * Added reducer to save state of height. * Added maxHeight for clinicalAggregations and ssmaggregations. * Swtich to another package to get height. * Removed reducer of dynamicStyle. * Added missing maxHeight. * Changed variable name. * Added comments for height calculation. * [PRTL-2548] Fix Truncated Sample Text in Days to Birth (#2529) * Changed the padding for rangeFacet. * Add max and min. * [PRTL-2549] Allow Choosing Years/Days for Age of Dx in Clinical Tab (#2532) * Allow Choosing Years/Days for Age of Dx. * Changed at to At. * PRTL-2543 add box plot table * PRTL-2540 capitalise specific terms at CDAVE * Removed e.g. from tooltips. * Added padding. * Updated graphql schema. * Update schema. * Added minHeight for NoResultsMessage in ExplorePage. (#2552) * [PRTL-2567] improve variable grouping and sorting (#2557) * [PRTL-2588] improve custom sorting to show more and less (#2561) Rather than using flexbox sorting, it actually reorganises the array itself. Also reduces “no data available” messages’ font size, as per @rosibaj’s earlier request. * Merged develop into this. * Fixed conflicts. * Remove follow-up and molecular tests from Clinical Tab (#2578) * delete prettier
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.