This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
🚧- No slides in json tooltip #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added to download.
alex-wilmer
reviewed
Apr 4, 2018
| @@ -84,7 +84,7 @@ export default compose( | |||
| arrangeColumnKey="exploreCases" | |||
| total={cases.hits.total} | |||
| endpoint="case_ssms" | |||
| downloadTooltip="Export All Except #Mutations and #Genes" | |||
| downloadTooltip="Export All Except #Mutations, #Genes and Slides" | |||
There was a problem hiding this comment.
why do Mutations and Genes have a #, but Slides does not?
There was a problem hiding this comment.
I just realized it must literally be "number of" genes or mutations...the table header has the hash mark too.
There was a problem hiding this comment.
What makes you sure it must literally be "number of"?
Not being sceptical, genuinely curious
There was a problem hiding this comment.
Hehe it just occurred to me when I saw your comment. But not actually based in logic particularly...tbh I'm not sure why those columns would have it and not the others
There was a problem hiding this comment.
this is a hilarious convo :P Reason for the # will have to ask @phuongmy
cy
approved these changes
Apr 4, 2018
cy
pushed a commit
that referenced
this pull request
May 24, 2018
* 🚧 - Adding slides to json exclusion tooltip until slide count can be added to download.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show slides in excluded tooltip until slide file count can be added to json download