Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

1891 real paginate ae #2225

Merged
merged 2 commits into from
Dec 11, 2017
Merged

1891 real paginate ae #2225

merged 2 commits into from
Dec 11, 2017

Conversation

cy
Copy link
Contributor

@cy cy commented Nov 22, 2017

No description provided.

@cy cy force-pushed the 1891-real-paginate-ae branch 10 times, most recently from 4c92a4f to 487ea84 Compare November 27, 2017 18:17
@cy cy force-pushed the 1891-real-paginate-ae branch from 487ea84 to 4aded29 Compare December 8, 2017 17:37
}
>
{Object.keys(fieldToDisplay).map(field => (
<DropdownItem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add cursor: 'pointer' here?

Copy link
Contributor

@alex-wilmer alex-wilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice. Three clickable places that could use cursor: pointer, but otherwise great job.

{!!searchValue.length && (
<CloseIcon
style={{
position: 'absolute',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, cursor: pointer here

<Row
style={{
padding: '0 4px 0 4px',
marginBottom: '-1px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursor: pointer?

@cy cy force-pushed the 1891-real-paginate-ae branch from 4aded29 to 50d52b2 Compare December 11, 2017 19:46
@cy
Copy link
Contributor Author

cy commented Dec 11, 2017

@alex-wilmer thanks, cursor pointered

@cy cy merged commit a9625da into next Dec 11, 2017
@cy cy deleted the 1891-real-paginate-ae branch December 11, 2017 19:55
alex-wilmer pushed a commit that referenced this pull request Dec 11, 2017
* ✨ PRTL-1891 File: paginate assoc. entities
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants