Write fix to prevent vlen-strings being compressed with zlib #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Tested as working (locally) to fix the issue at hand, with test passes from this branch using my netcdf4 v1.6.0 + Python v3.10 as well as my netcdf4 v1.5.6 + Python v3.9 conda environments.
Obviously we already have a test which captures the issue (hence how we noticed this immediately with Python 3.10 since it updates to use netcdf4 1.6.0 and induced this, yay!).
Excellent, please merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199