RRTMGP in ufs #23
RRTMGP in ufs #23
Conversation
dustinswales
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
| @@ -193,12 +193,16 @@ elif [[ $MACHINE_ID = hera.* ]]; then | |||
| ECFLOW_START=/scratch2/NCEPDEV/fv3-cam/Dusan.Jovic/ecflow/bin/ecflow_start.sh | |||
| ECF_PORT=$(( $(id -u) + 1500 )) | |||
| QUEUE=debug | |||
| # ACCNR=fv3-cpu | |||
| PARTITION= | ||
| # | ||
| # DTC baseline | ||
| dprefix=/scratch1/BMC/gmtb | ||
| DISKNM=$dprefix/ufs-weather-model/RT | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Please revert. There are also merge conflict marks in this file, please fix.
| @@ -207,6 +211,7 @@ elif [[ $MACHINE_ID = hera.* ]]; then | |||
| #STMP=$dprefix/stmp4 | |||
| #PTMP=$dprefix/stmp2 | |||
| # | |||
| >>>>>>> 2919f28a56fb3127fca33976c4840cad156be4d1 | |||
| @@ -326,7 +331,7 @@ mkdir -p ${RUNDIR_ROOT} | |||
| CREATE_BASELINE=false | |||
| ROCOTO=false | |||
| ECFLOW=false | |||
| KEEP_RUNDIR=false | |||
| KEEP_RUNDIR=true | |||
|
@climbfuji |
|
@dustinswales I need to get the current round of PRs merged into the official repositories/branches first before I can return to your PR. There are too many overlapping changes that need to be addressed one after the other. I can set up the regression test when I pull your changes into the latest version of the code if that's ok by you. |
|
@dustinswales I can't pull this PR in, because it contains changes and merge conflict marks in several files that I had asked you to revert. Since this PR does nothing except updating the submodule pointer for fv3atm, is it ok for you to close it (only this PR for ufs-weather-model, of course)? I'll have to create another PR anyway, whether this being a complementary or replacement one. Thanks! Here is the replacement PR: #29 |
|
Thanks! |
|
@climfuji I closed PR #23
…On Wed, Mar 18, 2020 at 6:29 AM Dom Heinzeller ***@***.***> wrote:
@dustinswales <https://github.com/dustinswales> I can't pull this PR in,
because it contains changes and merge conflict marks in several files that
I had asked you to revert. Since this PR does nothing except updating the
submodule pointer for fv3atm, is it ok for you to close it (only this PR
for ufs-weather-model, of course)? I'll have to create another PR anyway,
whether this being a complementary or replacement one. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKNQ2OYSQVEQSGH7ARP76DRIC5DZANCNFSM4K2MXYMA>
.
--
----------------------------------------------------------------------------------
Dustin Swales
Associate Scientist III
CIRES /NOAA-ESRL
(303)-497-7008
[email protected]
----------------------------------------------------------------------------------
|
…ructures gsd/develop: handle blocked data structures in init and finalize routines, remove pset logic, metadata cleanup
This PR updates the submodule pointers to use fv3atm with RRTMGP enabled CCPP physics:
NCAR/ccpp-physics#400