Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release-notes.rst #392

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Update release-notes.rst #392

merged 1 commit into from
Mar 30, 2023

Conversation

hCraker
Copy link
Contributor

@hCraker hCraker commented Mar 30, 2023

PR Summary

Addresses #391. Updates release notes for v2023.03.2 patch

PR Checklist

General

  • [n/a] Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add appropriate labels to this PR
  • [n/a] Make your changes in a forked repository rather than directly in this repo
  • [n/a] Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • [n/a] Request @NCAR/geocat for reviews
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@hCraker hCraker added high priority release Related to a package release labels Mar 30, 2023
@hCraker hCraker requested a review from anissa111 March 30, 2023 03:10
@hCraker
Copy link
Contributor Author

hCraker commented Mar 30, 2023

Link check is failing due to the release notes referencing a change log for a tag (v2023.03.2) that doesn't exist yet. It will be resolved once we merge this and I publish the release/new tag on GitHub

@hCraker
Copy link
Contributor Author

hCraker commented Mar 30, 2023

pydata_sphinx_theme had a new release late yesterday that is causing the doc failures. It looks like they did a bunch of refactoring today, but unless we are building our docs using their main branch, I'm not sure that's the cause. I'm looking into it right now

@hCraker
Copy link
Contributor Author

hCraker commented Mar 30, 2023

I think this is the commit in pydata-sphinx-theme that broke things for our checks pydata/pydata-sphinx-theme@0b58fca

An issue has already been opened on their repo. It looks like that issue might not be with them? pydata/pydata-sphinx-theme#1274

@anissa111 anissa111 merged commit 1cdecea into main Mar 30, 2023
@anissa111 anissa111 deleted the release-notes-2023.03.2 branch July 18, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to a package release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants