Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating quick start guide as part of overall docs improvements #249

Merged
merged 35 commits into from
Sep 21, 2022

Conversation

hCraker
Copy link
Contributor

@hCraker hCraker commented Sep 12, 2022

Closes #240
Part of prep for October tutorial #239
Addresses part of overall doc improvements #245

@hCraker hCraker added documentation Improvements or additions to documentation high priority ready for review Development is done and ready for reviews labels Sep 12, 2022
@hCraker hCraker requested a review from anissa111 September 12, 2022 15:56
@hCraker hCraker added work in progress and removed ready for review Development is done and ready for reviews labels Sep 12, 2022
@hCraker hCraker removed the request for review from anissa111 September 12, 2022 18:56
@hCraker hCraker added ready for review Development is done and ready for reviews and removed work in progress labels Sep 14, 2022
@hCraker hCraker requested a review from anissa111 September 14, 2022 17:33
@hCraker hCraker changed the base branch from main to docs September 14, 2022 19:33
@anissa111
Copy link
Member

@hCraker I included that one comment above for something I saw immediately, but I'd really like to be able to check out the rendered RTD pages. Could you merge the docs branch in to this branch to pull over the fix?

@hCraker hCraker requested a review from anissa111 September 14, 2022 20:45
GeoCAT-comp's open-source nature allows for more community engagement than a traditional software development workflow
does. As advances are made in the realm of geoscience, new tools will be needed to analyze new datasets. We are dedicated
to addressing user needs and encourage users to submit feature requests and contributions to our GitHub as well as
participate in discussions. See our `support <support>`_ page for info on how to submit bug reports and requests and how to get involved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
participate in discussions. See our `support <support>`_ page for info on how to submit bug reports and requests and how to get involved.
participate in discussions. See our `support <support>`_ page for info on how to submit bug report, feature requests, and how to get involved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right this needs rewording. How does this sound?

See our support <support>_ page for info on how to submit bug reports, request new
features, and get involved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that sounds better!

@@ -65,3 +66,4 @@ extra:
- erogluorhan # O. Eroglu https://github.com/erogluorhan
- anissa111 # A. Zacharias https://github.com/anissa111
- michaelavs # M. Sizemore https://github.com/michaelavs
- hcraker # H. Craker https://github.com/hcraker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to be removing this file here soon, you should add this change to the feedstock repo instead!

Comment on lines 5 to 9
Usage Examples
==============

Short Tutorial
--------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need both headers if we're going to drop the second subhead. Maybe we could do something like:

Suggested change
Usage Examples
==============
Short Tutorial
--------------
Quick Start Examples
--------------------
For more comprehensive examples, go check out :ref:`examples`

Disclaimer: I have no idea if that linkage will actually work


Short Tutorial
--------------
Calculate saturation vapor pressure from :code:`Numpy` Data::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Calculate saturation vapor pressure from :code:`Numpy` Data::
Calculate saturation vapor pressure from ``numpy`` data::

Thankfully, we don't have to do the full code directive to get this notation anymore

GeoCAT-comp's open-source nature allows for more community engagement than a traditional software development workflow
does. As advances are made in the realm of geoscience, new tools will be needed to analyze new datasets. We are dedicated
to addressing user needs and encourage users to submit feature requests and contributions to our GitHub as well as
participate in discussions. See our `support <support>`_ page for info on how to submit bug reports and requests and how to get involved.
Copy link
Member

@anissa111 anissa111 Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link here actually doesn't work. I think you might want to do something like :ref:support

Edit: Sorry, I can't get the formatting right on the comment. I'm talking about this: https://sublime-and-sphinx-guide.readthedocs.io/en/latest/references.html

they are based upon is wrapped in Python in the GeoCAT-f2py (Fortran 2 Python) package. GeoCAT-f2py is imported by
GeoCAT-comp and included in the GeoCAT-comp namespace. Simply, this means that GeoCAT-f2py functions can be called
through GeoCAT-comp, so there is no need for users to import GeoCAT-f2py directly in their scripts. Information about
GeoCAT-f2py can be found on the `package's homepage <https://geocat-f2py.readthedocs.io/en/>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, my bad, apparently RTD doesn't like that link. Let's do:

Suggested change
GeoCAT-f2py can be found on the `package's homepage <https://geocat-f2py.readthedocs.io/en/>`_.
GeoCAT-f2py can be found on the `package's homepage <https://geocat-f2py.readthedocs.io/>`_.

@hCraker hCraker requested a review from anissa111 September 16, 2022 15:35
functions in pure Python. With so many tools being used under the hood, GeoCAT-comp users have access to geoscience
specific computational tools without needing extensive working knowledge of `Pangeo <https://pangeo.io/>`_ stack.

There are syntactical benefits to using the Pangeo stack, once of which is indexing by label. NCL requires the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "one of which"

Heather Craker and others added 2 commits September 19, 2022 09:43
@anissa111 anissa111 merged commit 79cb6be into docs Sep 21, 2022
@anissa111 anissa111 deleted the quick-start branch September 21, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready for review Development is done and ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Getting Started" section to docs
3 participants