Initial support for farming out trials on >1 GPUs per node #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djgagne
reviewed
Sep 7, 2023
echo/optimize.py
Outdated
|
|
||
| # Check if "trials_per_job" is specified in hyper_config[batch_type] | ||
| if ( | ||
| "trials_per_job" in hyper_config[batch_type] |
There was a problem hiding this comment.
change parameter name to "tasks_per_worker"
katiedagon
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What still needs to me updated are the names of the config params: trials_per_job, and the newly added gpus_per_node. trials_per_job simply duplicates the number of python calls, which is multiplied by gpus_per_node (if >=1). What else should we name trials_per_job so its less ambiguous?