Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Integration with Nvidia compiler #435

Closed
wants to merge 127 commits into from

Conversation

dustinswales
Copy link
Collaborator

This PR introduces support to use the SCM with NVidia HPC fortran compiler (nvfortran).
The CI tests build and run a set of regression tests using the SCM_RAP suite for two configurations, one without and one with GPU support. GPU runtime functionality is not tested, just the build step.

@dustinswales
Copy link
Collaborator Author

dustinswales commented Mar 6, 2024

@grantfirl This one is good to go whenever we want to add it!
Up to 21 CI tests now!

@dustinswales
Copy link
Collaborator Author

Note that the Debug builds are failing (mersenne_twister conflict) with Nvidia, so I have them off in the yaml file.

if: contains(matrix.enable-gpu-acc, 'False')
run: |
cd ${SCM_ROOT}/scm/bin
./run_scm.py --file /home/runner/work/ccpp-scm/ccpp-scm/test/rt_test_cases.py --runtime_mult 0.1 -v
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grantfirl @mkavulich @scrasmussen
This is incomplete, it only runs the RTs, it doesn't download baselines and compare them. We should add these steps in and store a copy of the Nvidia Baselines on the DTC FTP server, analogous to the GNU based ones we have there.
So instead of rt-baselines-Release.zip and rt-baselines-Debug.zip on the DTC FTP server we will have:
rt-baselines-Debug.GNU.zip, rt-baselines-Release.GNU.zip, rt-baselines-Debug.NVHPC.zip, rt-baselines-Release.NVHPC.zip.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, no rt-baselines-Debug.NVHPC.zip, this test is off because it fails due to a naming conflict (mersenne_twister).

@grantfirl
Copy link
Collaborator

Combined into #459

@grantfirl grantfirl closed this Apr 11, 2024
@mkavulich
Copy link
Collaborator

@dustinswales @grantfirl It appears as if the CI test of this workflow is failing in the main branch. Since it seems like it was working on the last commit here, perhaps there was a problem with the merged PR?

@grantfirl
Copy link
Collaborator

@dustinswales @grantfirl It appears as if the CI test of this workflow is failing in the main branch. Since it seems like it was working on the last commit here, perhaps there was a problem with the merged PR?

See comments here: #459

@dustinswales dustinswales deleted the feature_nvidiaCI branch July 1, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants