Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-dev PR#64 #381

Merged
merged 2 commits into from
Jun 13, 2023
Merged

UFS-dev PR#64 #381

merged 2 commits into from
Jun 13, 2023

Conversation

grantfirl
Copy link
Collaborator

Contains changes analogous to NCAR/fv3atm#94 for working with NCAR/ccpp-physics#1015

@dustinswales
Copy link
Collaborator

@grantfirl Looks like the RAP twpice test differs, which is expected, but not the other RAP tests?

@grantfirl
Copy link
Collaborator Author

@grantfirl Looks like the RAP twpice test differs, which is expected, but not the other RAP tests?

Ya, it is a bit surprising that the arm_sgp_summer_1997_A case does not also differ with the RAP suite because it is the only other case that features deep convection and would have a chance at triggering the GF code changes. But, I'm assuming that whatever convection occurs in the SGP case is not strong enough to trigger the code changes, perhaps?

@dustinswales
Copy link
Collaborator

That's what I suspect.
I don't have a sense for the forcing in the all of the test cases or how this change manifests itself within the convection. I know we are only running 0.1x of these cases for our tests, and TWPICE is the longest test, which maybe is why it's triggering the convection?

@grantfirl
Copy link
Collaborator Author

That's what I suspect. I don't have a sense for the forcing in the all of the test cases or how this change manifests itself within the convection. I know we are only running 0.1x of these cases for our tests, and TWPICE is the longest test, which maybe is why it's triggering the convection?

Ya, that's yet another reason for the ARM case to not differ that I always forget (that we're only running 10% of the case model time), since I think the deep convection probably doesn't happen right away.

@grantfirl grantfirl merged commit e3065be into NCAR:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants