Add calls to initialize Noah LSM lookup tables to GFS_phys_time_vary #564
Conversation
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
|
@barlage FYI |
| !--- variables needed for calculating 'sncovr' | ||
| use namelist_soilveg, only: salp_data, snupx | ||
| #endif | ||
| use set_soilveg_mod, only: set_soilveg |
There was a problem hiding this comment.
@climbfuji Dom, this PR moves only the initialization of Noah LSM look-up tables to GFS_phys_time_vary because the snupx(vegtyp) and salp_data are needed to initialize snow cover fraction in the cold-start runs. Do I understand this PR correctly?
There was a problem hiding this comment.
If the answer to my question is 'yes', then the title of this PR could be changed to "Add calls to initialize Noah LSM lookup tables used in snow cover fraction computation". The look-up tables for RUC LSM (and Noah-MP) will still happen in lsm_ruc_init. We are not going to move them, right?
There was a problem hiding this comment.
Yes, correct. Mike and Helin will take care of the remaining Noah MP code in fv3atm.
There was a problem hiding this comment.
If the answer to my question is 'yes', then the title of this PR could be changed to "Add calls to initialize Noah LSM lookup tables used in snow cover fraction computation". The look-up tables for RUC LSM (and Noah-MP) will still happen in lsm_ruc_init. We are not going to move them, right?
Correct. I'll update the name of this PR.
There was a problem hiding this comment.
Sounds good. Thank you!
climbfuji
changed the title
…ork to support IAP model (NCAR#564) * fix for Aerosols (4d vars) causing PET log errors * Update CCPP Framework to support IAP model
This PR adds calls to initialize LSM lookup tables (soil vegetation parameters to
GFS_phys_time_vary.fv3.{F90,meta}.See NOAA-EMC/fv3atm#214 step 2 for more information.
Associated PRs:
#564
NOAA-EMC/fv3atm#244
ufs-community/ufs-weather-model#407
For regression testing information, see ufs-community/ufs-weather-model#407.