-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RRTMG cloud overlap method update (contains #477) #487
Merged
climbfuji
merged 6 commits into
NCAR:master
from
climbfuji:iacono_cloud_overlap_merged_with_rrtmgp_and_updated
Sep 25, 2020
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a609790
Update for new RRTMG cloud overlap methods EXP and ER
mjiacono b0bc1ab
Merge branch 'rrtmg-cloud-overlap-updates' of https://github.com/mjia…
climbfuji 5b50679
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into HEAD
climbfuji 4c5224a
Add dummy call to get_alpha_exp to physics/module_SGSCloud_RadPre.F90…
climbfuji 9bb1767
Merge branch 'master' of https://github.com/NCAR/ccpp-physics into ia…
climbfuji a8d1b6b
Update standard names for flags/controls of cloud overlap methods
climbfuji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the iovr=max(iovrlw,iovrsw) and it has variable options like, max-random, exp, exp-random, I would suggest to change the standard name to
standard_name = flag_for_cloud_overlapping_method_for_radiation
long_name = control flag for cloud overlapping method for radiation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur with this suggestion, though I prefer this wording:
standard_name = flag_for_cloud_overlap_method_for_radiation
long_name = control flag for cloud overlap method for radiation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzhangw @mjiacono In the cleanup of CCPP standard names that I'm working on, I already have changed this to:
control_for_radiation_cloud_overlap for the same reasons that you mentioned (it is not just for max-random). The switch to "control_for" is also because the word "flag" is being reserved for true logical switches, not integer controls like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I will use
flag_for_cloud_overlap_method_for_radiation
for now, becausecontrol_for_radiation_cloud_overlap
would be quite inconsistent with the current standard names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I assume I should make corresponding changes for
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also modified them in correct_unit branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, and I was going to ask you to revert this. The correct_unit branch is for fixing units, not for changing standard names (or any other unrelated radiation metadata updates - please remove all of them).