Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata corrections #474

Merged
merged 10 commits into from
Jul 15, 2020
1 change: 1 addition & 0 deletions physics/GFS_DCNV_generic.meta
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,7 @@
dimensions = ()
type = logical
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
Expand Down
27 changes: 17 additions & 10 deletions physics/GFS_GWD_generic.meta
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,23 @@
kind = kind_phys
intent = out
optional = F
[theta]
standard_name = angle_from_east_of_maximum_subgrid_orographic_variations
long_name = angle with_respect to east of maximum subgrid orographic variations
units = degrees
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = out
optional = F
[varss]
standard_name = standard_deviation_of_subgrid_orography_small_scale
long_name = standard deviation of subgrid orography small scale
units = m
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = in
intent = out
optional = F
[ocss]
standard_name = convexity_of_subgrid_orography_small_scale
Expand Down Expand Up @@ -102,15 +111,6 @@
kind = kind_phys
intent = out
optional = F
[theta]
standard_name = angle_from_east_of_maximum_subgrid_orographic_variations
long_name = angle with_respect to east of maximum subgrid orographic variations
units = degrees
dimensions = (horizontal_dimension)
type = real
kind = kind_phys
intent = out
optional = F
[sigma]
standard_name = slope_of_subgrid_orography
long_name = slope of subgrid orography
Expand Down Expand Up @@ -162,6 +162,7 @@
type = real
kind = kind_phys
intent = inout
optional = F
[dvdt]
standard_name = tendency_of_y_wind_due_to_model_physics
long_name = meridional wind tendency due to model physics
Expand All @@ -170,6 +171,7 @@
type = real
kind = kind_phys
intent = inout
optional = F
[dtdt]
standard_name = tendency_of_air_temperature_due_to_model_physics
long_name = updated tendency of the temperature
Expand All @@ -187,6 +189,7 @@
type = real
kind = kind_phys
intent = inout
optional = F
[dv3dt]
standard_name = cumulative_change_in_y_wind_due_to_orographic_gravity_wave_drag
long_name = cumulative change in y wind due to orographic gravity wave drag
Expand All @@ -195,6 +198,7 @@
type = real
kind = kind_phys
intent = inout
optional = F
[dt3dt]
standard_name = cumulative_change_in_temperature_due_to_orographic_gravity_wave_drag
long_name = cumulative change in temperature due to orographic gravity wave drag
Expand All @@ -220,6 +224,7 @@
dimensions = ()
type = logical
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
Expand Down Expand Up @@ -368,6 +373,8 @@
units = flag
dimensions = ()
type = logical
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
Expand Down
32 changes: 32 additions & 0 deletions physics/GFS_PBL_generic.meta
Original file line number Diff line number Diff line change
Expand Up @@ -314,27 +314,35 @@
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = out
optional = F
[save_v]
standard_name = y_wind_save
long_name = y-wind before entering a physics scheme
units = m s-1
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = out
optional = F
[save_t]
standard_name = air_temperature_save
long_name = air temperature before entering a physics scheme
units = K
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = out
optional = F
[save_q]
standard_name = tracer_concentration_save
long_name = tracer concentration before entering a physics scheme
units = kg kg-1
dimensions = (horizontal_dimension,vertical_dimension,number_of_tracers)
type = real
kind = kind_phys
intent = out
optional = F
[ldiag3d]
standard_name = flag_diagnostics_3D
long_name = flag for 3d diagnostic fields
Expand All @@ -358,27 +366,34 @@
dimensions = ()
type = logical
intent = in
optional = F
[ugrs]
standard_name = x_wind
long_name = zonal wind
units = m s-1
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[vgrs]
standard_name = y_wind
long_name = meridional wind
units = m s-1
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[tgrs]
standard_name = air_temperature
long_name = model layer mean temperature
units = K
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
Expand Down Expand Up @@ -688,6 +703,7 @@
dimensions = ()
type = logical
intent = in
optional = F
[ldiag3d]
standard_name = flag_diagnostics_3D
long_name = flag for 3d diagnostic fields
Expand Down Expand Up @@ -1331,55 +1347,71 @@
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[vgrs]
standard_name = y_wind
long_name = meridional wind
units = m s-1
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[tgrs]
standard_name = air_temperature
long_name = model layer mean temperature
units = K
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[qgrs]
standard_name = tracer_concentration
long_name = model layer mean tracer concentration
units = kg kg-1
dimensions = (horizontal_dimension,vertical_dimension,number_of_tracers)
type = real
kind = kind_phys
intent = in
optional = F
[save_u]
standard_name = x_wind_save
long_name = x-wind before entering a physics scheme
units = m s-1
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[save_v]
standard_name = y_wind_save
long_name = y-wind before entering a physics scheme
units = m s-1
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[save_t]
standard_name = air_temperature_save
long_name = air temperature before entering a physics scheme
units = K
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
optional = F
[save_q]
standard_name = tracer_concentration_save
long_name = tracer concentration before entering a physics scheme
units = kg kg-1
dimensions = (horizontal_dimension,vertical_dimension,number_of_tracers)
type = real
kind = kind_phys
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
Expand Down
16 changes: 12 additions & 4 deletions physics/GFS_SCNV_generic.meta
Original file line number Diff line number Diff line change
Expand Up @@ -76,23 +76,25 @@
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
intent = out
optional = F
[save_v]
standard_name = y_wind_save
long_name = y-wind before entering a physics scheme
units = m s-1
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = in
intent = out
optional = F
[save_t]
standard_name = air_temperature_save
long_name = air temperature before entering a physics scheme
units = K
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = inout
intent = out
optional = F
[save_qv]
standard_name = water_vapor_specific_humidity_save
Expand All @@ -101,7 +103,7 @@
dimensions = (horizontal_dimension,vertical_dimension)
type = real
kind = kind_phys
intent = inout
intent = out
optional = F
[flag_for_scnv_generic_tend]
standard_name = flag_for_generic_shallow_convection_tendency
Expand All @@ -110,6 +112,7 @@
dimensions = ()
type = logical
intent = in
optional = F
[errmsg]
standard_name = ccpp_error_message
long_name = error message for error handling in CCPP
Expand Down Expand Up @@ -241,6 +244,7 @@
type = real
kind = kind_phys
intent = in
optional = F
[save_v]
standard_name = y_wind_save
long_name = y-wind before entering a physics scheme
Expand All @@ -249,6 +253,7 @@
type = real
kind = kind_phys
intent = in
optional = F
[save_t]
standard_name = air_temperature_save
long_name = air temperature before entering a physics scheme
Expand Down Expand Up @@ -284,6 +289,7 @@
type = real
kind = kind_phys
intent = inout
optional = F
[dv3dt]
standard_name = cumulative_change_in_y_wind_due_to_shallow_convection
long_name = cumulative change in y wind due to shallow convection
Expand All @@ -292,6 +298,7 @@
type = real
kind = kind_phys
intent = inout
optional = F
[dt3dt]
standard_name = cumulative_change_in_temperature_due_to_shallow_convection
long_name = cumulative change in temperature due to shal conv.
Expand Down Expand Up @@ -430,6 +437,7 @@
dimensions = ()
type = logical
intent = in
optional = F
[imfshalcnv]
standard_name = flag_for_mass_flux_shallow_convection_scheme
long_name = flag for mass-flux shallow convection scheme
Expand Down
2 changes: 1 addition & 1 deletion physics/GFS_rrtmg_pre.meta
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
standard_name = minimum_large_ice_fraction
long_name = minimum large ice fraction in F-A mp scheme
units = frac
dimensions = (2)
dimensions = (horizontal_dimension)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. flgmin is - in FV3 - a control parameter that is independent of horizontal grid decomposition and has length 2. From GFS_typedefs.F90:

    real(kind=kind_phys) :: flgmin(2)      = (/0.180,0.220/)          !< [in] ice fraction bounds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed.

type = real
kind = kind_phys
intent = in
Expand Down
Loading