Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) #355

climbfuji · 2019-11-18T21:40:20Z

This PR is associated and tested with the PRs listed below. For regression testing, see NCAR/ufs-weather-model#3.

Changes for ccpp-physics:

remove module samfshalcnv_post, add code to GFS_SCNV_generic_post instead (the code is used by both hedmf and sas)
move subroutine tridit from satmedmfvdif.F to tridi.f (also used by satmedmfvdifq.F); add guard to satmedmfvdif_init that checks for isatmedmf=0
add satmedmfvdifq (updated version of satmedmfvdif) and dependencies
add SAS deep and shallow convection schemes

…shalcnv_post, add code to GFS_SCNV_generic_post instead

…idi.f; add guard to satmedmfvdif_init that checks for isatmedmf=0

climbfuji · 2019-11-18T21:43:53Z

Associated PRs:
NCAR/ccpp-framework#241
#355
NCAR/fv3atm#3
NCAR/ufs-weather-model#3

ligiabernardet · 2019-11-18T21:46:34Z

I do not understand why satmedmfvdifq is referred to as HAFS-related in this PR. From comments in satmedmfvdifq's original commit, I understood it is a revised PBL scheme to address problems in the PBL structure of the GFS (UFS Weather Model). Can you clarify?

climbfuji · 2019-11-18T21:50:35Z

I do not understand why satmedmfvdifq is referred to as HAFS-related in this PR. From comments in satmedmfvdifq's original commit, I understood it is a revised PBL scheme to address problems in the PBL structure of the GFS (UFS Weather Model). Can you clarify?

I think this is my understanding. I thought this version was added and required by the HAFS folks, but that it has been adopted by others as well. I will change this to "updated" only. Thanks for the info.

…dmfvdifq (updated version of satmedmfvdif) and dependencies

…tion schemes

…ction

grantfirl · 2019-11-20T16:35:00Z

physics/mfpbltq.f

+!>\file mfpbltq.f
+!! This file contains the subroutine that calculates mass flux and
+!! updraft parcel properties for thermals driven by surface heating 
+!! for use in the TKE-EDMF PBL scheme (HAFS version).


Per the PR discussion, is this really the "HAFS" version?

Good catch. I'll fix the comment.

grantfirl · 2019-11-20T16:35:32Z

physics/mfpbltq.f

+!
+      use machine , only : kind_phys
+      use funcphys , only : fpvs
+      use physcons, grav => con_g, cp => con_cp


Related to issue #104

grantfirl · 2019-11-20T16:36:26Z

physics/mfscuq.f

@@ -0,0 +1,550 @@
+!>\file mfscuq.f
+!! This file contains the mass flux and downdraft parcel preperties
+!! parameterization for stratocumulus-top-driven turbulence (HAFS version).


Same comment as above RE: "HAFS" version

grantfirl · 2019-11-20T16:36:41Z

physics/mfscuq.f

+!
+      use machine , only : kind_phys
+      use funcphys , only : fpvs
+      use physcons, grav => con_g, cp => con_cp


related to issue #104

grantfirl · 2019-11-20T16:39:16Z

physics/satmedmfvdifq.F

@@ -0,0 +1,1416 @@
+!> \file satmedmfvdifq.F
+!! This file  contains the CCPP-compliant SATMEDMF scheme (HAFS version) which computes


same comment RE: HAFS

…AFS version" to "updated version"

grantfirl

Approved, although may want to revisit using HAFS in the comments. I called out issues with the constants for later cleanup as part of issue #104. I'm a little worried that there is a proliferation of PBL schemes with relatively minor differences among them that may be good candidates for unification and control via namelist parms.

climbfuji · 2019-11-20T16:45:34Z

Approved, although may want to revisit using HAFS in the comments. I called out issues with the constants for later cleanup as part of issue #104. I'm a little worried that there is a proliferation of PBL schemes with relatively minor differences among them that may be good candidates for unification and control via namelist parms.

I share your concerns about the proliferation. I fixed the comments, change all of them from "HAFS version" to "updated version" (that is how EMC calls it in GFS_typedefs.F90). This affects files mfpbltq.f, mfscuq.f, satmedmfvdifq.F and the chain of submodule pointers. Since this is a comment-only change, we do not need to rerun any of the tests.

@danrosen25

Add HAFS HYCOM/WW3/CDEPS coupling A. More details about the HAFS coupling related changes (from @danrosen25) - gfs_physics_nml namelist modification (inpunt.nml file) - added cpl_imp_mrg used in assign_importdata - added cpl_imp_dbg used in assign_importdata - assign_importdata subroutine modification - added argument jdat, which is used to timestamp cpl_imp_dbg output - if cpl_imp_mrg then assign_importdata will compare import data to missing_value (9.99e20). If import data equals missing value and import field is 'sea_surface_temperature' then Sfcprop%tsfco is set to Sfcprop%tsfc instead of import data. merged data is then stored in datar8, which is a local copy of the import data. - if cpl_imp_dbg then the merged data stored in datar8 is written out to netcdf files - realizeConnectedCplFields - added optional argument fill_value, which is used to fill completed ESMF_Field, defaults to 0.0 - fv3_cap - import data realized with 9.99e20 fill_value - module_fcst_grid_comp - removed commented out code in regional grid creation - fixed grid alignment for regional fcstGrid - added corner coordinates (edges) to regional fcstGrid, using internal ATM%lon_bnd and ATM%lat_bnd - writes forecast grid to NetCDF if DumpFields = true in nems.configure B. Added the following HAFS development related namelist options: cplice, rlmx, elmax, sfc_rlm (more details can be seen from NCAR/pull/701) C. Renamed and added HAFS related ccpp suites Co-authored-by: Jun.Wang <[email protected]> Co-authored-by: Jili Dong <[email protected]> Co-authored-by: Chunxi.Zhang-NOAA <[email protected]> Co-authored-by: andrew.hazelton <[email protected]> Co-authored-by: ZhanZhang-NOAA <[email protected]> Co-authored-by: Daniel Rosen <[email protected]> Co-authored-by: Grant Firl <[email protected]> Co-authored-by: Dom Heinzeller <[email protected]> Co-authored-by: Man.Zhang <[email protected]> Co-authored-by: Ufuk Turuncoglu <[email protected]>

climbfuji added 2 commits November 18, 2019 14:28

physics/GFS_SCNV_generic.*, physics/samfshalcnv.*: remove module samf…

8300bfa

…shalcnv_post, add code to GFS_SCNV_generic_post instead

physics/satmedmfvdif.*, physics/tridi.f: move subroutine tridit to tr…

3bec6c5

…idi.f; add guard to satmedmfvdif_init that checks for isatmedmf=0

climbfuji mentioned this pull request Nov 18, 2019

Bugfix libxml2 library location macOS, logging message for unit conversions, bugfix for metadata2html.py NCAR/ccpp-framework#241

Merged

climbfuji changed the title ~~Add SAS deep/shallow convection and satmedmfvdifq (HAFS version)~~ Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) Nov 18, 2019

climbfuji added 2 commits November 18, 2019 14:51

physics/satmedmfvdifq.* physics/mfpbltq.f physics/mfscuq.f: add satme…

e45cb37

…dmfvdifq (updated version of satmedmfvdif) and dependencies

physics/sascnvn.*, physics/shalcnv.*: add SAS deep and shallow convec…

2d5a8e8

…tion schemes

climbfuji force-pushed the add_sas_and_satmedmfvdifq branch from 096760f to 2d5a8e8 Compare November 18, 2019 21:52

This was referenced Nov 18, 2019

Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) to CCPP NCAR/fv3atm#3

Merged

Add regression tests for sas deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) NCAR/ufs-weather-model#3

Merged

physics/sascnvn.meta: bugfix, use correct variable for cloud work fun…

bd47378

…ction

climbfuji marked this pull request as ready for review November 20, 2019 14:43

climbfuji requested review from grantfirl, JulieSchramm and llpcarson as code owners November 20, 2019 14:43

grantfirl reviewed Nov 20, 2019

View reviewed changes

mfpbltq.f, mfscuq.f, satmedmfvdifq.F: change comments in code from "H…

cbbac67

…AFS version" to "updated version"

grantfirl approved these changes Nov 20, 2019

View reviewed changes

climbfuji merged commit a7c38a6 into NCAR:dtc/develop Nov 20, 2019

climbfuji deleted the add_sas_and_satmedmfvdifq branch June 27, 2022 03:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) #355

Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) #355

climbfuji commented Nov 18, 2019 •

edited

Loading

climbfuji commented Nov 18, 2019 •

edited

Loading

ligiabernardet commented Nov 18, 2019

climbfuji commented Nov 18, 2019

grantfirl Nov 20, 2019

climbfuji Nov 20, 2019

grantfirl Nov 20, 2019

grantfirl Nov 20, 2019

grantfirl Nov 20, 2019

grantfirl Nov 20, 2019

grantfirl left a comment

climbfuji commented Nov 20, 2019 •

edited

Loading

		@@ -0,0 +1,1416 @@
		!> \file satmedmfvdifq.F
		!! This file contains the CCPP-compliant SATMEDMF scheme (HAFS version) which computes

Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) #355

Add SAS deep/shallow convection and satmedmfvdifq (updated version of satmedmfvdif) #355

Conversation

climbfuji commented Nov 18, 2019 • edited Loading

climbfuji commented Nov 18, 2019 • edited Loading

ligiabernardet commented Nov 18, 2019

climbfuji commented Nov 18, 2019

grantfirl Nov 20, 2019

Choose a reason for hiding this comment

climbfuji Nov 20, 2019

Choose a reason for hiding this comment

grantfirl Nov 20, 2019

Choose a reason for hiding this comment

grantfirl Nov 20, 2019

Choose a reason for hiding this comment

grantfirl Nov 20, 2019

Choose a reason for hiding this comment

grantfirl Nov 20, 2019

Choose a reason for hiding this comment

grantfirl left a comment

Choose a reason for hiding this comment

climbfuji commented Nov 20, 2019 • edited Loading

climbfuji commented Nov 18, 2019 •

edited

Loading

climbfuji commented Nov 18, 2019 •

edited

Loading

climbfuji commented Nov 20, 2019 •

edited

Loading