-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccpp_prebuild: out-of-source builds for parallel cmake builds (target master) #218
ccpp_prebuild: out-of-source builds for parallel cmake builds (target master) #218
Conversation
Associated PRs: #218 (previously branches "cmake_rt_gnu_and_ccpp" of gerrit:FV3 and gerrit:NEMSfv3gfs, but these are now out of date) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some repeated def write
methods but otherwise looks okay (as long as my question at the end does not stir up any angst).
scripts/mkstatic.py
Outdated
def write_sourcefile(self, source_filename): | ||
success = True | ||
filepath = os.path.split(source_filename)[0] | ||
if not os.path.isdir(filepath): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No if filepath
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! I will add the guard here as well.
…ired for parallel cmake builds in NEMSfv3gfs
77035ae
to
1358ecf
Compare
This PR is no longer required, however we should keep it for further reference. The changes for the CCPP out of source build are now contained in ufs-community/ufs-weather-model#1 and associated PRs. The changes specific to the cmake_rt approach need to be consolidated with the new cmake version that EMC is working on (based on their separate ongoing efforts) and merged into the new fv3atm and ufs-weather-model repositories. |
Modifications of ccpp_prebuild.py to support out-of-source builds for static CCPP builds, required for parallel cmake builds in NEMSfv3gfs.
Backward compatible for in-source builds for both static and dynamic builds.