changes to pioc.c, pio_lists.c to support async, also some temporary code #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e files for async development
edhartnett
changed the title
|
|
||
| /* If asynch IO is in use, send the PIO_MSG_EXIT message from the | ||
| * comp master to the IO processes. */ | ||
| if (ios->async_interface && !ios->comp_rank) |
There was a problem hiding this comment.
I find !ios->comp_rank a confusing way to point to comp rank 0. I wonder if we should introduce a constant - say COMP_MASTER_RANK set to 0 so that we have ios->comp_rank == COMP_MASTER_RANK ? Do the same for IO_MASTER_RANK?
There was a problem hiding this comment.
I have changed it to ios->comp_rank == 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request there are changed for pioc.c, mostly in the finalize function. The changes to compmaster and iomaster are in accordance with MPI docs and pass all tests.
There is also a change to pio_lists.c, which used to change the ncids when run with async. That doesn't work with the async code I wrote, so I have taken it out and cleaned up the function, as well as addind documentation.
The pull request also includes copies of three code files, which will be used for async development. The original code files are generated by perl scripts. After async development is complete, I will modify the perl scripts to output the async-capable code, and remove these three files. For now I would like to merge them to master before I make async changes, so you can easily see the changes that I make.