Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lengths of names of atts/vars/dims sent to tasks where rank != 0 for serial io types #54

Merged
merged 3 commits into from
Feb 8, 2016

Conversation

edhartnett
Copy link
Collaborator

In current code, the null terminator is not broadcast to tasks where rank != 0 for serial formats on PIOc_inq_varname/dimname/attname.

@jedwards4b
Copy link
Contributor

pio_nc.c is generated from file pio_c_template.c using ncparser.pl.
The correct place to make this change is around line 262 of ncparser.pl
The new pio_nc.c file is then generated by running
perl ncparser.pl $PNETCDF_INC_PATH $NETCDF_INC_PATH

make sure to use pnetcdf 1.6.1 or newer and netcdf 4.3.3.1 for the locations of the include directories.

@edhartnett
Copy link
Collaborator Author

OK, thanks for pointing that out!

I have changed the branch to reflect this.

Thanks,
Ed

jedwards4b added a commit that referenced this pull request Feb 8, 2016
Fix lengths of names of atts/vars/dims sent to tasks where rank != 0 for serial io types
@jedwards4b jedwards4b merged commit 65df1e8 into master Feb 8, 2016
@edhartnett edhartnett deleted the ejh_15 branch February 9, 2016 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants