Removed in-loop declarations from test_nc4.c #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging in changes from the root
…CMakeList compiler options.
Katetc
added a commit
that referenced
this pull request
Dec 21, 2015
Removed in-loop declarations from test_nc4.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to declare a variable inside of a for loop (as: "for(int i...") many compilers require the -c99 flag. To add this flag in cmake, we'd have to edit CMakeLists in the tests directory, or the examples directory, or any other directory where it is used. I think, perhaps, it would be easier to follow the c conventions in the rest of the PIO code and just declare the loop counter variables at the beginning of the function. I updated test_nc4.c to this, and now the project compiles without any extra CMakeList mucking about.