Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ejh doc #34

Merged
merged 6 commits into from
Nov 28, 2015
Merged

Ejh doc #34

merged 6 commits into from
Nov 28, 2015

Conversation

edhartnett
Copy link
Collaborator

Document examplePio.c. Also fix a bug in example code (decomposition array was not one-based). Also add a -v command line option to help debugging.

@jedwards4b
Copy link
Contributor

Hi Ed,

It just occured to me to tell you to look at the performance test as another
good, albeit more complicated, example.

Looking through the pull request something doesn't seem quite right to me.

At line 221 the DataBuffer is assigned
this->myrank + VAL
So I would expect the results for four procs to be:
{42,42,42,42,43,43,43,43,44,44,44,44,45,45,45,45}
and different from the result using 1,2,8 or 16 procs.

That's not consistent with line 550. Also line 550 shows the final value as missing?

The decomp array is indeed 1 based, and 0 has a special meaning - it means to skip this array location
in the read or write operation.

@edhartnett
Copy link
Collaborator Author

Good catch! The documentation was incorrect in this case, it showed the ncdump from a file before I fixed the bug with the compdof array. I've checked in a fix that updates the docs and shows the ncdump for a 4-processor run, which is as you expect:
foo = 42, 42, 42, 42, 43, 43, 43, 43, 44, 44, 44, 44, 45, 45, 45, 45 ;

jedwards4b added a commit that referenced this pull request Nov 28, 2015
Updating documentation in examples
@jedwards4b jedwards4b merged commit 6810404 into master Nov 28, 2015
@edhartnett edhartnett deleted the ejh_doc branch December 1, 2015 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants