Comments for PIOc_write_darray() #186
Conversation
| @@ -282,10 +283,16 @@ int PIOc_write_darray(const int ncid, const int vid, const int ioid, | |||
| /* Is this a record variable? */ | |||
| recordvar = vdesc->record >= 0 ? true : false; | |||
|
|
|||
| /* Check that ??? is not the same as length of data being | |||
There was a problem hiding this comment.
Check that the local size of the variable passed in matches the size expected by the io descriptor.
| @@ -298,6 +305,7 @@ int PIOc_write_darray(const int ncid, const int vid, const int ioid, | |||
| /* separate record and non-record variables */ | |||
| if (recordvar) | |||
| { | |||
| /* What is going on here?? */ | |||
There was a problem hiding this comment.
wmb is write multi buffer and is a pointer to one or more variables that fit the same description. We are moving to the end of the wmb linked list to add the current variable.
| @@ -361,34 +382,38 @@ int PIOc_write_darray(const int ncid, const int vid, const int ioid, | |||
|
|
|||
| /* Get memory for data. */ | |||
| if (arraylen > 0) | |||
| if (!(wmb->data = bgetr(wmb->data, (1+wmb->validvars)*arraylen*tsize))) | |||
| if (!(wmb->data = bgetr(wmb->data, (1 + wmb->validvars) * arraylen * tsize))) | |||
| piomemerror(*ios, (1 + wmb->validvars) * arraylen * tsize, __FILE__, __LINE__); | |||
|
|
|||
| /* Get memory for ??? */ | |||
| if (!(wmb->vid = (int *)bgetr(wmb->vid, sizeof(int) * (1 + wmb->validvars)))) | |||
There was a problem hiding this comment.
vid is an array of variable ids in the wmb list, grow the list and add the new entry.
| piomemerror(*ios, (1 + wmb->validvars) * arraylen * tsize, __FILE__, __LINE__); | ||
|
|
||
| /* Get memory for ??? */ | ||
| if (!(wmb->vid = (int *)bgetr(wmb->vid, sizeof(int) * (1 + wmb->validvars)))) | ||
| piomemerror(*ios, (1 + wmb->validvars) * sizeof(int), __FILE__, __LINE__); | ||
|
|
||
| /* Get memory for ??? */ |
There was a problem hiding this comment.
wmb->frame is the record number, we assume that the variables in the wmb list may not all have the same unlimited dimension value although they usually do.
|
|
||
| /* ??? */ |
There was a problem hiding this comment.
add the unlimited dimension value of this variable to the frame array in wmb
| @@ -1,7 +1,5 @@ | |||
| /** | |||
| * @file | |||
| /* | |||
There was a problem hiding this comment.
You've tried to simplify this test and that's fine, but instead of replacing a working test why not create a new one?
There was a problem hiding this comment.
This is not really a working test. If you look, you will see it does nothing with darrays (yet). It is just the start of the darray test I am writing. (The same is true of test_darray_async.c) They started as code copied from a test creating a more complex test file. In this first darray outing I am going to keep it very simple. ;-)
I have added comments to PIOc_write_darray(). Please review the comments and tell me what I got wrong. ;-)
I have used double-question marks where I am confused. If you could provide some comments for those places, that would really speed things up.
This is related to #89.