FA in fv_regional_bc and external_ic #17

mzhangw · 2020-07-31T20:56:56Z

This PR focus on two topics:

In fv_regional_bc: initialize q_rimef and add the cloud physics auto conversion routine for FA scheme.
Fix the ntrac> ntracers limitation in external_ic.
Add temperature rebalance in the last step of Lagrangian_to_Eulerian step
Fix a delz bug in subroutine neg_adj2
Further optimize the use of q_rimef in fv_dynamic

Full RTs passed except fv3_ccpp_gfdlmp_hwrfsas generated non-bit4bit results due to a known fix in CCPP HWRF physics.

- In fv_regional_bc: initialize q_rimef and add the cloud physics auto conversion routine for FA scheme.

model/fv_dynamics.F90

climbfuji · 2020-08-03T15:28:03Z

model/fv_sg.F90

@@ -2138,7 +2166,9 @@ subroutine neg_adj2(is, ie, js, je, ng, kbot, hydrostatic,   &
        qv(i,j,k) = qv2(i,j)
        ql(i,j,k) = ql2(i,j)
        qi(i,j,k) = qi2(i,j)
+        if (present(qs)) then
        qs(i,j,k) = qs2(i,j)


adjust indent (add three spaces)

climbfuji · 2020-08-03T15:28:47Z

tools/external_ic.F90

-      if (ntrac > ntracers) call mpp_error(FATAL,'==> External_ic::get_nggps_ic: more NGGPS tracers &
-                                 &than defined in field_table '//trim(fn_gfs_ctl)//' for NGGPS IC')
+!mzhang: not in FA
+!      if (ntrac > ntracers) call mpp_error(FATAL,'==> External_ic::get_nggps_ic: more NGGPS tracers &


Do we know why this test has been added there? Are there any potentially dangerous consequences if ntrac > ntracers?

The max number of NGGPS tracers (ntrac) is predefined in gfs_ctrl.nc as 7. I guess that it was the max tracers supported at that time?

Yeah, but why did they put the requirement there? Is there anything wrong if the number of tracers in the file is larger than what is used? I don't see what should be wrong, but you never know if there is some code elsewhere that relies on this condition. But maybe other code changes have made this check superfluous. Let's comment it out as you suggested and see what GFDL says when we want to merge it back.

I don't know if the modification here will impact other places either.

!zhang nwat=4
if ( Atm%flagstruct%nwat .eq. 4 ) then
do k=1,npz
BC_side%q_BC(i,j,k,rainwat) = 0.
BC_side%q_BC(i,j,k,q_rimef) = 0.
BC_side%q_BC(i,j,k,snowwat) = 0.
BC_side%q_BC(i,j,k,graupel) = 0.
.......
q_BC is defined by (:,:,:,1:ntracers). So I don't think snowwat and graupel need to be included here.
I am not sure if mp_auto_conversion_fa is necessary.

…an step - fix a delz bug in subroutine neg_adj2 - further optimize the use of q_rimef in fv_dynamic

climbfuji

I am ok with these changes, but I would like to ask @ChunxiZhang-NOAA to look at this and approve, too. We will need PRs for fv3atm and ufs-weather-model for the submodule pointer updates; @mzhangw please create those to prepare for committing the code. Thanks!

mzhangw · 2020-08-06T03:48:39Z

Done. NCAR/ufs-weather-model#63

…

On Aug 5, 2020, at 4:31 PM, Dom Heinzeller ***@***.***> wrote: @climbfuji commented on this pull request. I am ok with these changes, but I would like to ask @ChunxiZhang-NOAA <https://github.com/ChunxiZhang-NOAA> to look at this and approve, too. We will need PRs for fv3atm and ufs-weather-model for the submodule pointer updates; @mzhangw <https://github.com/mzhangw> please create those to prepare for committing the code. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2WDGL6TDZ57PWU6RALR7HMVZANCNFSM4PQ4JI7Q>.

mzhangw · 2020-08-06T15:48:56Z

For now, it does not impact all existing RTs and makes HWRF physics working with ntrac = 6 in field_table (no cld_amt). Man

…

On Aug 6, 2020, at 9:12 AM, ChunxiZhang-NOAA ***@***.***> wrote: @ChunxiZhang-NOAA commented on this pull request. In tools/external_ic.F90 <#17 (comment)>: > @@ -570,8 +570,9 @@ subroutine get_nggps_ic (Atm, fv_domain, dt_atmos ) !--- read in the number of tracers in the NCEP NGGPS ICs call read_data ('INPUT/'//trim(fn_gfs_ctl), 'ntrac', ntrac, no_domain=.TRUE.) - if (ntrac > ntracers) call mpp_error(FATAL,'==> External_ic::get_nggps_ic: more NGGPS tracers & - &than defined in field_table '//trim(fn_gfs_ctl)//' for NGGPS IC') +!mzhang: not in FA +! if (ntrac > ntracers) call mpp_error(FATAL,'==> External_ic::get_nggps_ic: more NGGPS tracers & I don't know if the modification here will impact other places either. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2TWW3JS2HU7BCZYST3R7LB47ANCNFSM4PQ4JI7Q>.

ChunxiZhang-NOAA

for fv_regional_bc.F90

!zhang nwat=4
if ( Atm%flagstruct%nwat .eq. 4 ) then
do k=1,npz
BC_side%q_BC(i,j,k,rainwat) = 0.
BC_side%q_BC(i,j,k,q_rimef) = 0.
BC_side%q_BC(i,j,k,snowwat) = 0.
BC_side%q_BC(i,j,k,graupel) = 0.
.......
q_BC is defined by (:,:,:,1:ntracers). So I don't think snowwat and graupel need to be included here.
I am not sure if mp_auto_conversion_fa is necessary.

ChunxiZhang-NOAA · 2020-08-06T15:39:59Z

tools/external_ic.F90

-      if (ntrac > ntracers) call mpp_error(FATAL,'==> External_ic::get_nggps_ic: more NGGPS tracers &
-                                 &than defined in field_table '//trim(fn_gfs_ctl)//' for NGGPS IC')
+!mzhang: not in FA
+!      if (ntrac > ntracers) call mpp_error(FATAL,'==> External_ic::get_nggps_ic: more NGGPS tracers &


!zhang nwat=4
if ( Atm%flagstruct%nwat .eq. 4 ) then
do k=1,npz
BC_side%q_BC(i,j,k,rainwat) = 0.
BC_side%q_BC(i,j,k,q_rimef) = 0.
BC_side%q_BC(i,j,k,snowwat) = 0.
BC_side%q_BC(i,j,k,graupel) = 0.
.......
q_BC is defined by (:,:,:,1:ntracers). So I don't think snowwat and graupel need to be included here.
I am not sure if mp_auto_conversion_fa is necessary.

mzhangw · 2020-08-06T15:54:35Z

good catch!

…

On Aug 6, 2020, at 9:49 AM, ChunxiZhang-NOAA ***@***.***> wrote: @ChunxiZhang-NOAA commented on this pull request. for fv_regional_bc.F90 !zhang nwat=4 if ( Atm%flagstruct%nwat .eq. 4 ) then do k=1,npz BC_side%q_BC(i,j,k,rainwat) = 0. BC_side%q_BC(i,j,k,q_rimef) = 0. BC_side%q_BC(i,j,k,snowwat) = 0. BC_side%q_BC(i,j,k,graupel) = 0. ....... q_BC is defined by (:,:,:,1:ntracers). So I don't think snowwat and graupel need to be included here. I am not sure if mp_auto_conversion_fa is necessary. In tools/external_ic.F90 <#17 (comment)>: > @@ -570,8 +570,9 @@ subroutine get_nggps_ic (Atm, fv_domain, dt_atmos ) !--- read in the number of tracers in the NCEP NGGPS ICs call read_data ('INPUT/'//trim(fn_gfs_ctl), 'ntrac', ntrac, no_domain=.TRUE.) - if (ntrac > ntracers) call mpp_error(FATAL,'==> External_ic::get_nggps_ic: more NGGPS tracers & - &than defined in field_table '//trim(fn_gfs_ctl)//' for NGGPS IC') +!mzhang: not in FA +! if (ntrac > ntracers) call mpp_error(FATAL,'==> External_ic::get_nggps_ic: more NGGPS tracers & !zhang nwat=4 if ( Atm%flagstruct%nwat .eq. 4 ) then do k=1,npz BC_side%q_BC(i,j,k,rainwat) = 0. BC_side%q_BC(i,j,k,q_rimef) = 0. BC_side%q_BC(i,j,k,snowwat) = 0. BC_side%q_BC(i,j,k,graupel) = 0. ....... q_BC is defined by (:,:,:,1:ntracers). So I don't think snowwat and graupel need to be included here. I am not sure if mp_auto_conversion_fa is necessary. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2TNO5VYLIMCLNRBLVLR7LGIHANCNFSM4PQ4JI7Q>.

climbfuji · 2020-08-07T13:26:22Z

for fv_regional_bc.F90

!zhang nwat=4
if ( Atm%flagstruct%nwat .eq. 4 ) then
do k=1,npz
BC_side%q_BC(i,j,k,rainwat) = 0.
BC_side%q_BC(i,j,k,q_rimef) = 0.
BC_side%q_BC(i,j,k,snowwat) = 0.
BC_side%q_BC(i,j,k,graupel) = 0.
.......
q_BC is defined by (:,:,:,1:ntracers). So I don't think snowwat and graupel need to be included here. I am not sure if mp_auto_conversion_fa is necessary.

@ChunxiZhang-NOAA please submit a follow-up PR to correct whatever needs to be corrected. Thanks!

* commit of new version of dycore from Weather and Climate Dynamics Group at GFDL * updated versions of GFDL-specific files from dev/gfdl * updated README.md with current release information * cleaned up a few lines in fv_dynamics * new file RELEASE.md with release notes documenting differences between this and the last release * updated RELEASE.md message * hand merge of diagnostic updates * remove trailing spaces from sources * updates to merge some GFDL specific updates into this public release

Pull GCC fix from develop to MAPL-2.0

- fix the ntrac> ntracers limitation in external_ic.

5dd06bb

- In fv_regional_bc: initialize q_rimef and add the cloud physics auto conversion routine for FA scheme.

mzhangw requested a review from climbfuji as a code owner July 31, 2020 20:56

add negative hydrometeors adjustment for F-A scheme

1951678

climbfuji requested changes Aug 3, 2020

View reviewed changes

- add temperature rebalance in the last step of lagrangian_to_Euleri…

1ae0439

…an step - fix a delz bug in subroutine neg_adj2 - further optimize the use of q_rimef in fv_dynamic

climbfuji reviewed Aug 5, 2020

View reviewed changes

mzhangw mentioned this pull request Aug 6, 2020

Add c96/regional/FA RT configuration for HAFS application NCAR/ufs-weather-model#63

Closed

climbfuji approved these changes Aug 6, 2020

View reviewed changes

climbfuji merged commit fd80f7d into NCAR:dtc/hafs-develop Aug 6, 2020

ChunxiZhang-NOAA reviewed Aug 6, 2020

View reviewed changes

climbfuji pushed a commit to climbfuji/GFDL_atmos_cubed_sphere that referenced this pull request Apr 24, 2024

Merge pull request NCAR#17 from GEOS-ESM/geos/develop

f5e6a63

Pull GCC fix from develop to MAPL-2.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FA in fv_regional_bc and external_ic #17

FA in fv_regional_bc and external_ic #17

mzhangw commented Jul 31, 2020 •

edited

Loading

climbfuji Aug 3, 2020

climbfuji Aug 3, 2020

mzhangw Aug 3, 2020

climbfuji Aug 3, 2020

ChunxiZhang-NOAA Aug 6, 2020

ChunxiZhang-NOAA Aug 6, 2020

climbfuji left a comment

mzhangw commented Aug 6, 2020 via email

mzhangw commented Aug 6, 2020 via email

ChunxiZhang-NOAA left a comment

ChunxiZhang-NOAA Aug 6, 2020

mzhangw commented Aug 6, 2020 via email

climbfuji commented Aug 7, 2020

FA in fv_regional_bc and external_ic #17

FA in fv_regional_bc and external_ic #17

Conversation

mzhangw commented Jul 31, 2020 • edited Loading

climbfuji Aug 3, 2020

Choose a reason for hiding this comment

climbfuji Aug 3, 2020

Choose a reason for hiding this comment

mzhangw Aug 3, 2020

Choose a reason for hiding this comment

climbfuji Aug 3, 2020

Choose a reason for hiding this comment

ChunxiZhang-NOAA Aug 6, 2020

Choose a reason for hiding this comment

ChunxiZhang-NOAA Aug 6, 2020

Choose a reason for hiding this comment

climbfuji left a comment

Choose a reason for hiding this comment

mzhangw commented Aug 6, 2020 via email

mzhangw commented Aug 6, 2020 via email

ChunxiZhang-NOAA left a comment

Choose a reason for hiding this comment

ChunxiZhang-NOAA Aug 6, 2020

Choose a reason for hiding this comment

mzhangw commented Aug 6, 2020 via email

climbfuji commented Aug 7, 2020

mzhangw commented Jul 31, 2020 •

edited

Loading