Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BGC Feature default input directory #225

Closed
OmkarSaMo opened this issue Jan 30, 2023 · 1 comment
Closed

BGC Feature default input directory #225

OmkarSaMo opened this issue Jan 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@OmkarSaMo
Copy link
Contributor

Since we are using data/interim/bgcs as input for the BiGSCAPE rule, I think its also best to use the same directory for the default selection of BGC pipeline. Currently there are few renamed BGCs that cant be found in data/interim/antismash directory.

@matinnuhamunada this is just a suggestion, if you have a strong reason to use antiSMASH directory as default then that's fine. As I can manually add correct locations in the sample.csv anyway.

bgcflow/workflow/rules/bgc_selection.smk

Line 5 in 70378e0

antismash_path = Path(f"data/interim/antismash/{antismash_version}")

@OmkarSaMo OmkarSaMo added the enhancement New feature or request label Jan 30, 2023
@matinnuhamunada
Copy link
Collaborator

Agree :) Current implementation is a quick fix. Will implement this next.

@matinnuhamunada matinnuhamunada mentioned this issue Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matinnuhamunada @OmkarSaMo