Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gdal webview #192

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Gdal webview #192

merged 4 commits into from
Apr 6, 2020

Conversation

markpet49
Copy link
Member

Description of the Change

Update to fix an illegal GDAL access and deprecate the old WebView functionality.

@markpet49 markpet49 requested a review from Beak-man February 3, 2020 23:35
@Beak-man
Copy link
Member

Beak-man commented Apr 1, 2020

Regarding the ColladaViewer and ColladaMovingModel examples, I see that most of the COLLADA models do not have texture maps or lights:

image

The duck is meant to have a texture map. This is not a change induced by your PR (I cannot find the texture files in the repo), they must have been taken out by mistake prior to the migration to GitHub. The duck is a reference model for the format, do you think it will be worthwhile to add its texture file back? It can be found here:

https://github.com/KhronosGroup/COLLADA-CTS/blob/master/StandardDataSets/collada_other/library_geometries/geometry/mesh/lines/duck_lines/duckCM.tga

In regards to illumination effects, should the models have lights? This is how the COLLADA cube looks like in WebWW, for instance:

image

The duck in WebWW is textured and illuminated:

image

@markpet49
Copy link
Member Author

@Beak-man I moved these examples back to their original location in the test folder. The Collada code needs some work and you can't override the lighting and texture at this point.

Copy link
Member

@Beak-man Beak-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested an assortment of examples.

@Beak-man Beak-man merged commit 5999df6 into develop Apr 6, 2020
@Beak-man Beak-man deleted the gdal-webview branch April 6, 2020 23:03
@PJHogan
Copy link

PJHogan commented Apr 6, 2020

Yann would be delighted!

quonn77 pushed a commit to quonn77/WorldWindJava that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants