Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix elevation processing issues duning rendering #237

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix elevation processing issues duning rendering #237

wants to merge 2 commits into from

Conversation

ComBatVision
Copy link

@ComBatVision ComBatVision commented Dec 7, 2020 •
edited
Loading

Description of the Change

  • Added globe.getElevationAtLocation() method to determine real (not-tessellated) elevation at specified location.
  • Fixed GL near clip distance calculation and limit Navigator to avoid camera below terrain.
  • Fixed lookAt position calculation for gestures to rotate around point on terrain (not at zero altitude point).
  • Add Elevation value output into exabple application.
  • Tests which uses Navigator were commented as it is now dependent on Android context.

Why Should This Be In Core?

There was a terrain tessellation implemented in previous release, but it has been not involved in camera clip distance calculation and gestures processing.
As the result camera is now rotating around the point below the surface and may render below the surface which cause graphical artifacts.

Benefits

Correct behavior of camera respecting terrain elevation.

Potential Drawbacks

None

@ComBatVision
Add elevationAtLocation determination in the Globe.
e546ee4 
Calculate correct GL near clip distance and limit Navigator to avoid terrain collisions.
Fix lookAt point calculation for gesture begin - take terrain altitude in consideration.
Add terrain elevation output into example application.
Navigator tests were commented as it is now dependent on context.
@ComBatVision ComBatVision mentioned this pull request Dec 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PJHogan PJHogan PJHogan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ComBatVision @PJHogan