Remove upper bound for tile imagery resolution. #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
On the current develop branch, worldwind limits the resolution of image tiles to 0.5m. When visualizing scenes which are low to the ground (such as geolocated vehicles) this can be insufficient resolution to view a scene in full detail.
This PR removes the artificial limit in
mustSubdivide
, which in turn allows the layer providers to regain control over the maximum resolution they can support. For example, the Bing tiled image layer supports 23 levels of imagery, some of which are unavailable before this MR becausemustSubdivide
begins returning false before the higher levels are reached. A side-by-side comparison of using theBingAerialLayer
before and after this MR is below:develop
branchWhy Should This Be In Core?
The current resolution limit is hard-coded in core, thus must be modified there.
Benefits
The ability to render arbitrarily small scenes, which would commonly include situations such as geolocated vehicles and 3D renders of individual buildings.
Potential Drawbacks
The current limit may be there to reduce accidental bandwidth usage. In this case I'd request that a configurable option be included to set the minimum tile resolution to something other than 0.5.