-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add surface shape performance test #701
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @zglueck. I noticed a few small things that need adjustment:
-
functionalTest should be registered as a WebStorm test root. I've pushed changes for this.
-
The functional test files need more descriptive names. I anticipate be lots of functional tests covering various aspects (performance correctness, etc). Each test needs to be easily identifiable. How about SurfaceShapePerformance.html/js.
-
The functional test files need to start a folder hierarchy. Let's use mirror the src folder hierarchy, like test does.
-
I think we should drop the graph. I'm unable to make any real meaningful inference with it. The frame time data, however, is useful and serve the need the graph intends to.
@pdavidc I've addressed 2, 3, and 4; however I need guidance with 1. With the
Using an alternative server (e.g. python) allows the functional test to run, but WebStorm's built-in seems to be changing the content type header on my machine. Is there a workaround for the content type in WebStorm? |
@zglueck The content-type error is not the root of the problem. Registering the functionalTest folder as a test root affects the configuration of WebStorm's built-in web server. The paths to resources in src no longer work as expected. |
Description of the Change
This PR adds a functional test which measures SurfaceShape performance. Both static and moving surface shapes are tested using an automated navigation technique.
Applicable Issues
Closes #694