-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roundup action unstable releases appear to be unstable #52
Comments
unstable releases look like they're being properly marked as That was addressed here and in the linked ticket. Currently it looks like the snapshot releases are being removed as we expect but tags are not. See here: I imagine we'll want those stripped out. |
MJJoyce
added a commit
that referenced
this issue
Sep 16, 2021
Update Python roundup handling so that SNAPSHOT tags are, again, removed during out build. Changes in `pds-github-util` updated the Python snapshot release handling to use "SHAPSHOT" like our Java releases. It was missed that the check for these tags was hard coded to "*dev*" here. We may want to update this in the future so it's not hard coded. Or that might be wasted worked and not matter. This addresses one of the issues raised in #52
MJJoyce
added a commit
that referenced
this issue
Sep 16, 2021
Update Python roundup handling so that SNAPSHOT tags are, again, removed during out build. Changes in `pds-github-util` updated the Python snapshot release handling to use "SHAPSHOT" like our Java releases. It was missed that the check for these tags was hard coded to "*dev*" here. We may want to update this in the future so it's not hard coded. Or that might be wasted worked and not matter. This addresses one of the issues raised in #52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Describe the bug
📜 To Reproduce
Steps to reproduce the behavior:
🕵️ Expected behavior
Pre-Release
and, for python, maybe renamed to something cleaner (is there something standard others use)?The text was updated successfully, but these errors were encountered: