Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roundup action unstable releases appear to be unstable #52

Closed
jordanpadams opened this issue Jul 19, 2021 · 3 comments
Closed

roundup action unstable releases appear to be unstable #52

jordanpadams opened this issue Jul 19, 2021 · 3 comments
Assignees
Labels
B12.0 bug Something isn't working s.medium

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jul 19, 2021

🐛 Describe the bug

  1. unstable releases are being tagged as stable releases
  2. past unstable releases are not being cleaned up from the repo

📜 To Reproduce

Steps to reproduce the behavior:

  1. See https://github.com/NASA-PDS/pds-template-repo-python/releases/latest points to a dev release generated by this unstable CICD action
  2. See https://github.com/NASA-PDS/pds-template-repo-python/releases for all the past dev releases included (oops! i cleaned these up... but trust me. it happens)

🕵️ Expected behavior

  1. Unstable releases should be tagged as Pre-Release and, for python, maybe renamed to something cleaner (is there something standard others use)?
  2. Cleanup of old dev releases - Up for discussion. I see both sides of this. Having all past tagged versions is great for complete transparency. maybe we only cleanup at each stable release (or if the tag already exists)?
@MJJoyce
Copy link
Contributor

MJJoyce commented Sep 16, 2021

unstable releases look like they're being properly marked as SNAPSHOT at the moment:
https://github.com/NASA-PDS/pds-github-util/releases

That was addressed here and in the linked ticket.

Currently it looks like the snapshot releases are being removed as we expect but tags are not. See here:
Screen Shot 2021-09-16 at 14 06 23

I imagine we'll want those stripped out.

MJJoyce added a commit that referenced this issue Sep 16, 2021
Update Python roundup handling so that SNAPSHOT tags are, again, removed
during out build. Changes in `pds-github-util` updated the Python snapshot
release handling to use "SHAPSHOT" like our Java releases. It was missed
that the check for these tags was hard coded to "*dev*" here. We may
want to update this in the future so it's not hard coded. Or that might
be wasted worked and not matter.

This addresses one of the issues raised in #52
MJJoyce added a commit that referenced this issue Sep 16, 2021
Update Python roundup handling so that SNAPSHOT tags are, again, removed
during out build. Changes in `pds-github-util` updated the Python snapshot
release handling to use "SHAPSHOT" like our Java releases. It was missed
that the check for these tags was hard coded to "*dev*" here. We may
want to update this in the future so it's not hard coded. Or that might
be wasted worked and not matter.

This addresses one of the issues raised in #52
MJJoyce added a commit that referenced this issue Sep 17, 2021
Update the Python release BuildStep to label releases with `SNAPSHOT`
instead of `dev` for consistency with changes made in #52 and #57.

Resolve #62
@MJJoyce
Copy link
Contributor

MJJoyce commented Sep 17, 2021

Note, after #62 / #63 are merged I think (please don't jinx it, please don't jinx it) that this can be marked as resolved.

@nutjob4life
Copy link
Member

Issue #62 is closed and #63 is merged so closing 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 bug Something isn't working s.medium
Projects
None yet
Development

No branches or pull requests

3 participants