-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement reindexing sweeper #155
base: main
Are you sure you want to change the base?
Conversation
this currently yields strange results which may indicate that OS/python are inconsistent in their lexical sorting
…dest This avoids issues where ES/python have inconsistent lexical sort approaches
TODO: implement argparse CLI
without this in place prior to migration, the reindexer sweeper will fail
… documents this is a bandaid, but should be replaced by detection/handling of "RequestError(400, 'illegal_argument_exception', 'ReleasableBytesStreamOutput cannot hold more than 2GB of data'" such that
…me resolution and all calls
this was removed during rebase/merge in d0b85a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request still has boilerplate:
One of the following should be included here:
Reference to regression test included in code (preferred wherever reasonable)
Attach test data here + outputs of tests
Any of those outputs available to replace the boilerplate?
I tried running the tests myself with tox -e py39
but got 4 failed, 39 passed, 120 warnings, 8 errors
so I might be running them wrong 🤷
Sorry, meant to open this as a draft PR - will update and re-request review later |
@alexdunnjpl no worries! Converted to "draft". Thanks! |
…nant_index_name()
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request description … still has boilerplate text 🤷
Visual inspection of code … looks fine ✓
Running tox -e py39
… get 51 passed, 120 warnings
🎉
Approval: ✅
🗒️ Summary
Implements reindexing sweeper/script
Implements support for aliased indices in all sweepers code
⚙️ Test Data and/or Report
One of the following should be included here:
♻️ Related Issues
Related to NASA-PDS/registry#339 (comment)
Related to NASA-PDS/registry#329
Related to NASA-PDS/registry#338