Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not implemented yet that maybe turned into 404 #49

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Patch for set status in NASA-PDS/registry-mgr#73

⚙️ Test Data and/or Report

See NASA-PDS/registry-mgr#73

♻️ Related Issues

#36
NASA-PDS/registry-mgr#66

@tloubrieu-jpl
Copy link
Member

Hi @al-niessner ,

That did not fix my issue in registry-mgr, or it looks worse actually, see:

% ./bin/registry-manager set-archive-status \            
    -auth /Users/loubrieu/Documents/pds/registry/es-auth.txt \
    -es file:///Users/loubrieu/Documents/pds/registry/mcp_dev.xml \
    -lidvid urn:nasa:pds:insight_rad:data_derived::7.0 \
    -status archived -v DEBUG
[ERROR] null

Is there a way you can test that on your side ?

Thanks,

Thomas

@al-niessner
Copy link
Contributor Author

@tloubrieu-jpl

Do you have this and PR #50 installed? I think that any error is badly butchered by registry-mgr and so this ticket fixed a NotImplementedError to 404 while if #50 is not installed it is being translated to null. It works for me:

SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[INFO] Setting product status. LIDVID = urn:nasa:pds:insight_rad:data_derived::7.0, status = archived

Ran it at 0913 hrs PDT June 26, 2024.

@tloubrieu-jpl
Copy link
Member

Thanks @al-niessner , I tested from the branch mgr_66 so I would need to merge this branch in issue_50 so that it works. I can do that.

@tloubrieu-jpl tloubrieu-jpl changed the base branch from main to issue_50 June 26, 2024 20:36
@tloubrieu-jpl tloubrieu-jpl merged commit ab3f452 into issue_50 Jun 26, 2024
3 checks passed
@tloubrieu-jpl tloubrieu-jpl deleted the mgr_66 branch June 26, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants