Refactor membership endpoints to support AOSS and add test cases #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdunnjpl
force-pushed
the
edunn-membership-endpoints
branch
2 times, most recently
from
2b80b08 to
2bfb351
Compare
- implement member-of and member-of/member-of endpoints - implement RegistrySearchRequestBuilder methods matchFieldAnyOf() and matchFieldAnyOfIdentifiers()
…functions - apply default behaviour of resolving LID to latest-LIDVID and only allowing non-superseded results in output data - implement ProductsController.resolveIdentifierToLidvid() - implement member-of and member-of/member-of endpoints - important explanatory comment - implement members and members/members products subroutes
alexdunnjpl
force-pushed
the
edunn-membership-endpoints
branch
from
ce42d7e to
0547f29
Compare
|
Ready for review. Sorry about the messy commit history - had some unintended overlap that stopped me squashing it perfectly. |
8 tasks
jordanpadams
changed the title
jordanpadams
changed the title
tloubrieu-jpl
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Reimplements requirements #223 #451 #452 #453 #454
Implements catch-all
BadRequestExceptionclass and handler, returning HTTP400⚙️ Test Data and/or Report
New tests added in NASA-PDS/registry#298
Happy-path tests implemented for all four endpoints.
HTTP400 paths tested manually
♻️ Related Issues
part of #424