registry-155 - Registry multi-tenancy #302
Conversation
…pecified id - enables multi-tenancy
…eader in place of node
jimmie
requested review from
tloubrieu-jpl,
alexdunnjpl and
al-niessner
as code owners
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| public static void addNodeFilter(BoolQueryBuilder boolQuery, String node) { | ||
| log.debug("addNodeFilter: " + node); | ||
|
|
||
| if (node == null || node.trim() == "") return; |
There was a problem hiding this comment.
opt.semgrep.java.lang.correctness.no-string-eqeq.no-string-eqeq: Strings should not be compared with ==.
This is a reference comparison operator.
Use .equals() instead.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
converted PR to Draft since it should not be merged yet |
|
Closing this PR as we move to a different architectural approach |
🗒️ Summary
Enable registry multi-tenancy : co-located documents from various nodes within a single Opensearch domain. Provide support for a 'node=' query parameter to all API endpoints which filters documents having 'ops:Harvest_Info/ops:node_name' equal to that value.
Also included is the modified CloudFront function which now passes an HTTP header 'x-request-version' that identifies the API version. This should be consumed by the EC2 Load Balancer rules to direct to the appropriate service (currently ECS/Fargate) endpoint/listener.
THIS PR SHOULD NOT BE MERGED AT THIS POINT IN TIME but is provided to ensure that all bases wrt the service code have been considered.
refs NASA-PDS/registry#155
refs #304