Issue #3: Implementation of multi-platform packaging with PyInstaller #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galenatjpl
reviewed
Apr 10, 2019
There was a problem hiding this comment.
This all looks good, except in principle I don't think we should be committing IDE-specific files (i.e. "PDS Inspect Tool.sublime-project") to the repo. Different developers will have different types of files, and different IDEs, etc...
I would remove this file, and add an expression for "*.sublime-project" to the .gitignore.
|
Removed. (Is "Sublime Text" really an IDE? It's hard to tell these days! 😄) |
|
Probably borderline IDE :)
It can do a lot of cool magic stuff!
On Apr 10, 2019, at 5:24 PM, Sean Kelly <[email protected]<mailto:[email protected]>> wrote:
Removed. (Is "Sublime Text" really an IDE? It's hard to tell these days! 😄)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#2 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AtVv3jqg5ADPPNH9Hy1ozceYfc6DMo5Aks5vfoDPgaJpZM4coWJl>.
|
jordanpadams
changed the title
jordanpadams
approved these changes
Apr 11, 2019
There was a problem hiding this comment.
Per comments from @galenatjpl and update from @nutjob4life we are good for merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks; this contains changes to support packaging the PDS Inspect Tool for macOS, Windows, and Linux environments. The
README.rstcontains details on how to do it. This should provide support to PDS-660.Resolves #3