Joss dev #18
Merged
Joss dev #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
init returns nothing (joss rev)
removed object inheritance from class constructor
small typos; wrong variables not detected
variables do not shadow built-in names anymore
updated typing in classes
6 tasks
marcsit
approved these changes
Jul 6, 2022
|
@SimonMolinsky thank you very much for your work as part of the JOSS review. This is excellent feedback that not only cleans up the code but also instructs me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
__init__()method should return nothing,object, there is no need to writeclass C(object)because it is equal toclass C.objecttype, in the most cases specific types are used, for some cases typing is skipped (to avoid circular imports).⚙️ Test Data and/or Report
One of the following should be included here:
NPB - Functional Tests - TestFunctional Tests data on: /tmp/tmp4yckx7ue * test_dart_host_type * test_dart_multiple_obs_tar * test_insight_basic * test_insight_diff_previous_all * test_insight_diff_previous_files * test_insight_diff_previous_log * test_insight_diff_previous_none * test_insight_diff_templates * test_insight_extra_mk_pattern * test_insight_files_in_staging * test_insight_flat_kernel_directory * test_insight_generate_mk * test_insight_incorrect_times * test_insight_increment_with_misc * test_insight_missing_staging_directory_nok * test_insight_mk_input * test_insight_mks_coverage_in_final * test_insight_mks_input * test_insight_mks_inputs_coverage * test_insight_no_kernels * test_insight_no_kernels_with_bundle * test_insight_no_readme * test_insight_no_readme_in_config * test_insight_no_spiceds * test_insight_no_spiceds_in_conf * test_insight_only_checksums * test_insight_previous_spiceds * test_insight_readme_incomplete_in_config * test_insight_start_finish * test_ladee_checksum_registry * test_ladee_date_format * test_ladee_label_mode * test_ladee_label_mode_ker_bun_dir * test_ladee_label_mode_ker_input * test_ladee_label_mode_plan_input * test_ladee_update_input_mk_name * test_m2020_duplicated_kernel * test_m2020_empty_spk * test_m2020_incorrect_mission_times * test_m2020_incorrect_start_time * test_m2020_increment_finish_time * test_m2020_increment_start_time * test_m2020_kernel_list * test_m2020_kernel_list_checks * test_m2020_kernel_list_dir * test_m2020_mks_incorrect_path * test_m2020_mks_inputs_coverage * test_m2020_spk_with_unrelated_id * test_maven_generate_mk * test_maven_increment_times_from_yearly_mks * test_maven_load_kernels * test_maven_mks_input * test_maven_mks_list * test_maven_mks_list_config_in_kernels * test_maven_mks_list_config_in_kernels_and_config * test_maven_mks_list_in_kernels * test_maven_no_mk * test_mro_basic NPB - Regression Tests - TestRegression Tests data on: /tmp/tmpi5mjlhko * test_em16 * test_insight * test_kplo * test_ladee * test_m2020 * test_msl NPB - Unit Tests - TestUnitTests Tests data on: /tmp/tmpfwxvdcad * test_binary_kernel_integrity * test_checksum_from_labels * test_checksum_from_record * test_ck * test_clear_label_mode * test_dsk_coverage * test_im_format * test_im_schema_incoherent * test_im_schema_resolution * test_im_templates * test_im_templates_11 * test_im_templates_14 * test_im_templates_16 * test_im_version_ascii * test_im_version_ascii_incorrect * test_im_xml_incoherent * test_insight_basic * test_insight_error * test_insight_history * test_insight_mk_double_keyword_in_pattern * test_insight_mk_double_keyword_in_pattern_no_gen * test_insight_mk_error_extra_pattern * test_insight_mk_error_wrong_name * test_match_patterns_basic * test_mk_to_list * test_pds3_big_endianness * test_pds3_juno_list * test_pds3_ltl_endianness * test_pds3_ltl_endianness_config * test_pds3_m01_list * test_pds3_mro_list * test_pds3_msl_list * test_pds3_orbnum_files * test_pds4_big_endianness * test_pds4_big_endianness_config * test_pds4_hyb2_list * test_pds4_insight_list * test_pds4_insight_plan * test_pds4_ltl_endianness * test_pds4_ltl_endianness_config * test_pds4_mars2020_list * test_pds4_mars2020_no_plan * test_pds4_maven_list * test_pds4_orbnum_blank_records * test_pds4_orbnum_blank_records_no_former * test_pds4_orbnum_blank_records_no_version * test_pds4_orbnum_coverage_archived_spk * test_pds4_orbnum_coverage_estimate * test_pds4_orbnum_coverage_increment_spk * test_pds4_orbnum_coverage_lookup_table * test_pds4_orbnum_coverage_lookup_table_multiple * test_pds4_orbnum_coverage_user_spk * test_pds4_orbnum_eol_line_feed * test_pds4_orbnum_generated_list * test_pds4_orbnum_multiple_files * test_pds4_orbnum_multiple_files_in_spk_dir * test_pds4_orbnum_multiple_files_incorrect_spk * test_pds4_orbnum_new_im * test_pds4_orbnum_with_former * test_pds4_orbnum_with_former_version * test_pds4_orex_list * test_pds4_vco_list * test_spk_coverage * test_text_kernel_integrity * test_xml_reader♻️ Related Issues
#17