Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue after the ingestion of a product fails #88

Merged
merged 6 commits into from
Mar 31, 2022
Merged

Conversation

tdddblog
Copy link
Contributor

@tdddblog tdddblog commented Mar 30, 2022

🗒️ Summary

Continue ingesting other products after the ingestion of a product fails.

NOTE: Valid use cases:

  • If you are ingesting a directory (<directories> configuration) or a manifest (<files> configuration), Harvest will continue after any product failure.
  • If you are ingesting a bundle (<bundles> configuration), Harvest will stop if the bundle or a collection ingestion fails. It will continue if any non-bundle or non-collection product type fails, such as an Observational product.

⚙️ Test Data and/or Report

  • Build commons project first (see Continue after the ingestion of a product fails registry-common#23)
  • Then build Harvest
  • Before ingesting data make one or more products invalid. For example, set <start_date_time> = "ABC" or <field_number> = "XYZ".
  • Run Harvest (use -O (overwrite) flag if you loaded the same data before)
  • Check that products with errors are skipped and valid products are loaded. See NOTE above for valid use cases.

♻️ Related Issues

nasa-pds-engineering-node/pds-registry-app#253
#84

@tdddblog tdddblog requested a review from tloubrieu-jpl March 30, 2022 01:21
@tloubrieu-jpl tloubrieu-jpl merged commit b8bb150 into main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants