Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harvest counting of ingested materials #226

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

al-niessner
Copy link
Contributor

@al-niessner al-niessner commented Jan 10, 2025

🗒️ Summary

Account for duplicate LIDVIDs.

⚙️ Test Data and/or Report

Comments in #147 show that with unique LIDVIDS, all number match as expected.

♻️ Related Issues

Closes #147
Closes #148
Closes #149

@al-niessner al-niessner self-assigned this Jan 10, 2025
@al-niessner al-niessner requested a review from a team as a code owner January 10, 2025 22:37
@al-niessner al-niessner marked this pull request as draft January 10, 2025 22:37
@al-niessner al-niessner marked this pull request as ready for review January 11, 2025 19:50
@jordanpadams jordanpadams changed the title fix harvest counting of ingested materials Fix harvest counting of ingested materials Jan 21, 2025
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @al-niessner

@tloubrieu-jpl tloubrieu-jpl merged commit b53c216 into main Jan 28, 2025
4 checks passed
@tloubrieu-jpl tloubrieu-jpl deleted the issue_14789 branch January 28, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants