issue 129: add .lblx #137
Merged
issue 129: add .lblx #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
harvest is still broken. While making these changes noticed two things:
|
| @@ -69,7 +69,7 @@ private static class BundleMatcher implements BiPredicate<Path, BasicFileAttribu | |||
| public boolean test(Path path, BasicFileAttributes attrs) | |||
| { | |||
| String fileName = path.getFileName().toString().toLowerCase(); | |||
| return (fileName.endsWith(".xml") && fileName.contains("bundle")); | |||
| return ((fileName.endsWith(".xml") || fileName.endsWith(".lbxl"))&& fileName.contains("bundle")); | |||
There was a problem hiding this comment.
@al-niessner sorry for the confusion. This is incorrect. This should be .lblx not .lblxl
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Minimal changes required to process .xml and .lblx files but may not what was desired nor the most optimal for future expansion beyond these two extensions.
⚙️ Test Data and/or Report
Not sure how to show a DB was populated in a meaningful way.
♻️ Related Issues
Closes #129
Closes #130