Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with PDS API version 1.4.0 #161

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Add compatibility with PDS API version 1.4.0 #161

merged 1 commit into from
Feb 26, 2024

Conversation

nutjob4life
Copy link
Member

@nutjob4life nutjob4life commented Feb 22, 2024

πŸ—’οΈ Summary

Merge this to make the Deep Archive compatible with PDS API version 1.4.0. Note that this is a backwards-incompatible change and will no longer support earlier versions of the PDS API.

βš™οΈ Test Data and/or Report

With earlier PDS API and older Deep Archive:

$ pds-deep-registry-archive --version
pds-deep-registry-archive 1.1.4
$ pds-deep-registry-archive  --quiet --site PDS_ATM urn:nasa:pds:magellan_gxdr::1.0
$ wc -l magellan_gxdr_v1.0_20240222_*
      84 magellan_gxdr_v1.0_20240222_aip_v1.0.xml
     109 magellan_gxdr_v1.0_20240222_checksum_manifest_v1.0.tab
     109 magellan_gxdr_v1.0_20240222_sip_v1.0.tab
      89 magellan_gxdr_v1.0_20240222_sip_v1.0.xml
     109 magellan_gxdr_v1.0_20240222_transfer_manifest_v1.0.tab
     500 total

With the 1.4.0 PDS API (currently hosted at https://pds.nasa.gov/api/search-en-gamma/1):

$ pds-deep-registry-archive --version
pds-deep-registry-archive 1.2.0
$ pds-deep-registry-archive  --quiet --url https://pds.nasa.gov/api/search-en-gamma/1 --site PDS_ATM urn:nasa:pds:magellan_gxdr::1.0
$ wc -l magellan_gxdr_v1.0_20240222_*
      84 magellan_gxdr_v1.0_20240222_aip_v1.0.xml
     109 magellan_gxdr_v1.0_20240222_checksum_manifest_v1.0.tab
     109 magellan_gxdr_v1.0_20240222_sip_v1.0.tab
      89 magellan_gxdr_v1.0_20240222_sip_v1.0.xml
     109 magellan_gxdr_v1.0_20240222_transfer_manifest_v1.0.tab
     500 total

♻️ Related Issues

@@ -55,9 +55,11 @@ install_requires =
lxml == 4.9.0 # Must be 4.9.0 for Windows compatibility with prebuilt https://www.lfd.uci.edu/~gohlke/pythonlibs/#lxml
zope.component ~= 5.0.1
zope.interface ~= 5.4.0
pds.api-client ~= 1.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nutjob4life , so you stopped using the api client 😒 ?
We'll see later if we can re-integrated that or the upper layer. I guess it was too unstable and you missed that /all feature.

Since we have that demo scheduled tomorrow with the nodes I will do the release now with the PR merged.

Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @tloubrieu-jpl! The client doesn't support the "/latest" or "/all" endpoints which I need to use. But the server itself is easy enough to take advantage of, so Python Requests works out great πŸŽ‰

@tloubrieu-jpl tloubrieu-jpl merged commit 4ece259 into main Feb 26, 2024
1 check passed
@tloubrieu-jpl tloubrieu-jpl deleted the i159 branch February 26, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants