-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color maps range slider implementation #1190
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @snmln! I left a couple of comments below
app/scripts/components/exploration/components/datasets/color-range-slider.scss
Outdated
Show resolved
Hide resolved
app/scripts/components/exploration/components/datasets/colorRangeSlider.tsx
Show resolved
Hide resolved
app/scripts/components/exploration/components/datasets/colorRangeSlider.tsx
Show resolved
Hide resolved
app/scripts/components/exploration/components/datasets/colorRangeSlider.tsx
Outdated
Show resolved
Hide resolved
app/scripts/components/exploration/components/datasets/colorRangeSlider.tsx
Show resolved
Hide resolved
app/scripts/components/exploration/components/datasets/colorRangeSlider.tsx
Show resolved
Hide resolved
@snmln Sorry, one more small nit: if we remove the min val from the input and then click outside of the input, could we revert back / show the default value instead of leaving the min input empty? |
As of right now that is the functionality on refresh. That shouldn't be hard to implement when the interface closes. |
app/scripts/components/exploration/components/datasets/colorRangeSlider.tsx
Show resolved
Hide resolved
migrating changes from color-maps-range-slider #1190
Related Ticket: #1102
Description of Changes
Creation and implementation of new range slider component.
Notes & Questions About Changes
-There is a identified bug that while dragging the slider thumbs you can drag the entire panel up and down influencing the parent component position.
-Additional functionality: If input field is left empty and clicked outside of the default min or max should auto populate the field.
Validation / Testing
Navigate to a data exploration and add a layer to the timeline.