Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color maps range slider implementation #1190

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Color maps range slider implementation #1190

merged 11 commits into from
Oct 18, 2024

Conversation

snmln
Copy link
Contributor

@snmln snmln commented Oct 10, 2024

Related Ticket: #1102

Description of Changes

Creation and implementation of new range slider component.

Notes & Questions About Changes

-There is a identified bug that while dragging the slider thumbs you can drag the entire panel up and down influencing the parent component position.
-Additional functionality: If input field is left empty and clicked outside of the default min or max should auto populate the field.

Validation / Testing

Navigate to a data exploration and add a layer to the timeline.

  • Layers:
    • Confirm that min and max are accurate to value in the layer legend view.
    • Switch to another layer with different value confirm that the min and max in the range slider are accurate.
    • Select a layer with a min value less than 0 (net ecosystem exchange) you should see a middle marker that represents the center of the current gradient values.
  • Slider:
    • You should not be able to drag the min slider past the max slider, or the max slider past the min slider.
  • Text Inputs:
    • You should be able to type in a value greater or lower than the min max of the layer but then be shown with the error message Please enter a value between {min} and {max} no change to the slider range or the map.
    • After selecting a different max that is less than the layers absolute maximum with either slider or input, if you enter in a value in the min text input that is greater than the newly selected max you should be presented with an error message Please enter a value less than {max}
    • After selecting a different min that is larger than the layers absolute minimum with either slider or input, if you enter in a value in the max text input that is greater than the newly selected max you should be presented with an error message Please enter a value larger than {min}

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit fa9a363
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/671174f57bfef700083fe9cf
😎 Deploy Preview https://deploy-preview-1190--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@snmln snmln marked this pull request as ready for review October 10, 2024 17:49
@snmln snmln requested review from dzole0311 and removed request for dzole0311 October 10, 2024 17:49
Copy link
Collaborator

@dzole0311 dzole0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @snmln! I left a couple of comments below

@dzole0311
Copy link
Collaborator

@snmln Sorry, one more small nit: if we remove the min val from the input and then click outside of the input, could we revert back / show the default value instead of leaving the min input empty?

@snmln
Copy link
Contributor Author

snmln commented Oct 17, 2024

@snmln Sorry, one more small nit: if we remove the min val from the input and then click outside of the input, could we revert back / show the default value instead of leaving the min input empty?

As of right now that is the functionality on refresh. That shouldn't be hard to implement when the interface closes.

@snmln snmln requested a review from dzole0311 October 17, 2024 20:35
@snmln snmln merged commit 233a31c into main Oct 18, 2024
8 checks passed
@snmln snmln deleted the color-maps-range-slider branch October 18, 2024 14:52
@hanbyul-here hanbyul-here mentioned this pull request Oct 29, 2024
snmln added a commit that referenced this pull request Oct 29, 2024
This reverts commit 233a31c, reversing
changes made to 46e1c5d.
snmln added a commit that referenced this pull request Nov 22, 2024
This reverts commit 233a31c, reversing
changes made to 46e1c5d.
snmln added a commit that referenced this pull request Nov 22, 2024
This reverts commit 233a31c, reversing
changes made to 46e1c5d.
@snmln snmln restored the color-maps-range-slider branch November 22, 2024 18:55
snmln added a commit that referenced this pull request Nov 27, 2024
This reverts commit 233a31c, reversing
changes made to 46e1c5d.
snmln added a commit that referenced this pull request Nov 27, 2024
snmln added a commit that referenced this pull request Nov 27, 2024
snmln added a commit that referenced this pull request Nov 27, 2024
snmln added a commit that referenced this pull request Nov 27, 2024
migrating changes from color-maps-range-slider #1190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants