Add isHidden prop for optional hiding of stories #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
hanbyul-here
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1088
Description of Changes
This ticket introduces a
isHiddenprop for both stories and datasets, so that they could be hidden from the appropriate catalogs. If a story has this new prop, then it will not be shown in the stories catalog, but it will still be known to the veda-ui and could be navigated to via routing.Example with "This is the life of water":
Stories catalog (hidden): https://deploy-preview-1090--veda-ui.netlify.app/stories
Story page: https://deploy-preview-1090--veda-ui.netlify.app/stories/life-of-water
Note: the story will still appear as a featured story unless
isFeaturedis also set to false in the .mdx, so it's pretty configurable.Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing
{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}