Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safelist react-calendar related classes #1080

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

dzole0311
Copy link
Collaborator

Related Ticket: {link related ticket here}

Description of Changes

This PR adds the react-calendar component as part of the safelist for purgeCSS not to remove some of its classes.

See the GHG update PR to v4.5.0 as an example of how the date picker would look like without this change:

Screenshot 2024-08-02 at 15 00 08

Should be as the screenshot below:

Screenshot 2024-08-02 at 15 01 33

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 0eb734b
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66ace404cf611a0008b1d4f7
😎 Deploy Preview https://deploy-preview-1080--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@hanbyul-here hanbyul-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@dzole0311 dzole0311 merged commit 60afe6d into main Aug 2, 2024
8 checks passed
@dzole0311 dzole0311 deleted the safelist-react-calendar-classes branch August 2, 2024 13:52
dzole0311 added a commit that referenced this pull request Aug 2, 2024
## 🎉 Features
-

## 🚀 Improvements
-

## 🐛 Fixes
- Safelist react-calendar related classes
#1080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants