Sort catalog items alphabetically in the E&A modal and the data catalog #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| isDatasetData(d) && | ||
| d.layers.sort((a, b) => a[sortField]?.localeCompare(b[sortField]) || 0) | ||
| })) as DatasetData[]; | ||
| } |
There was a problem hiding this comment.
I think
veda-ui/app/scripts/components/common/catalog/prepare-datasets.ts
Lines 75 to 81 in 03d0488
There was a problem hiding this comment.
The problem is that this will only work for the Data Catalog, where we show the datasets. But in the E&A Modal we show the layers within those datasets, so we have to go one level down (to the layers prop) to sort them. Showing the layers in the new E&A Modal makes it more obvious that they are unsorted as opposed to the old modal when we showed them horizontally and it was not as obvious.
sandrahoang686
approved these changes
Jul 9, 2024
sandrahoang686
added a commit
that referenced
this pull request
Jul 17, 2024
## 🎉 Features * 🦗 ## 🚀 Improvements - Base setup for using react-uswds in the veda-ui #1029 - Consolidate utils/veda-data(-no-faux-module) methods into new dir and remove faux module dependencies for Library build #1030 - Upgrade to Parcel 2.12 and make library build work #1045 - Update E&A Date Picker to react-calendar with USWDS tokens #1048 ## 🐛 Fixes - Sort catalog items alphabetically in the E&A modal and the data catalog #1039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: #1038
Description of Changes
Add fix that sorts catalog content alphabetically by default for the Data Catalog view and the E&A modal. This behavior was there for the Data Catalog before the last release, but not for the old E&A modal (due to it using horizontal cards).
Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing