Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort featured stories based on publication date #894

Closed
hanbyul-here opened this issue Mar 20, 2024 · 2 comments · Fixed by #907
Closed

Sort featured stories based on publication date #894

hanbyul-here opened this issue Mar 20, 2024 · 2 comments · Fixed by #907
Assignees
@sandesh-sp
Labels
good first issue Good for newcomers

Comments

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Mar 20, 2024 •
edited by j08lue
Loading

Our featured stories are not sorted by publication dates now. It will make the most sense to sort them by the dates.

image (1)
@j08lue j08lue added the good first issue Good for newcomers label Mar 20, 2024
@j08lue j08lue changed the title Sort Features stories based on publication dates Sort featured stories based on publication date Mar 21, 2024
@sandesh-sp sandesh-sp self-assigned this Mar 29, 2024
@sandesh-sp
Copy link
Contributor

Hi @hanbyul-here, just to confirm, should newer stories appear first (ordered from most recent to oldest)?

@sandesh-sp sandesh-sp mentioned this issue Mar 29, 2024
Merged
@sandesh-sp sandesh-sp linked a pull request Mar 29, 2024 that will close this issue
Sort featured stories based on publication date in descending order #907
Merged
@hanbyul-here
Copy link
Collaborator Author

hanbyul-here commented Mar 30, 2024 •
edited
Loading

@sandesh-sp Yes, the most recent one should come first!

j08lue added a commit that referenced this issue Apr 4, 2024
@j08lue
Sort featured stories based on publication date in descending order (#…
d8950b9 
…907)

### Description of Changes
Sorted the featuredItems on function FeaturedSliderSection based on
their publication date so that featured stories are ordered from most
recent to oldest

### Issue

Closes #894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandesh-sp sandesh-sp

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort featured stories based on publication date in descending order NASA-IMPACT/veda-ui
3 participants
@j08lue @hanbyul-here @sandesh-sp