Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[E & A] Fast follow ups after internal review #856

Closed
8 tasks done
faustoperez opened this issue Feb 22, 2024 · 4 comments
Closed
8 tasks done

[E & A] Fast follow ups after internal review #856

faustoperez opened this issue Feb 22, 2024 · 4 comments
Assignees
@faustoperez @sandrahoang686
Milestone
E&A Revision 3

Comments

@faustoperez
Copy link

faustoperez commented Feb 22, 2024 •
edited by sandrahoang686
Loading

This is a placeholder ticket if there are any fast design follow-ups after enabling the new E&A release

Tasks
Preview Give feedback
@faustoperez faustoperez self-assigned this Feb 22, 2024
@faustoperez faustoperez mentioned this issue Feb 26, 2024
Closed
1 task
@faustoperez
Copy link
Author

faustoperez commented Feb 26, 2024 •
edited
Loading

@sandrahoang686 @j08lue Here's a quick mockup of what the analysis options could look like. The cogs icon should stick to the top right corner and always be visible (during analysis mode).

US GHG Center - Timeline + analysis options

As a side note, in the near future we should revisit the analysis flow to work on the following:

  • Timeline analysis states
  • add 0 reference to vertical legend
  • show multiple charts
  • expand/collapse etc.
  • chart tooltip
  • chart styles
  • etc.

@sandrahoang686 sandrahoang686 mentioned this issue Feb 26, 2024
Merged
4 tasks
@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Feb 26, 2024 •
edited
Loading

PR #859
Completes the first 4 tasks...

  • select modal - update filter to remove redundant "Name" option
  • card - remove link from collection title
  • info modal - change button text to "Open in Data Catalog"
  • select modal - remove link from collection title on top of the modal

Analysis change will take a bit longer so separate PR to follow

@j08lue j08lue changed the title [E & A] [Placeholder] Fast follow ups after enabling new E&A [E & A] Fast follow ups after enabling new E&A Feb 27, 2024
@j08lue j08lue changed the title [E & A] Fast follow ups after enabling new E&A [E & A] Fast follow ups after internal review Feb 27, 2024
@j08lue j08lue added this to the E&A Revision 3 milestone Feb 27, 2024
sandrahoang686 added a commit that referenced this issue Feb 27, 2024
@sandrahoang686
[#856] A&E Fast Follow Tweaks (#859)
b566b3c 
This PR completes the following tasks in #856 

- [x] select modal - update filter to remove redundant "Name" option
- [x] card - remove link from collection title
- [x] select modal - remove link from collection title on top of the
modal
- [x] info modal - change button text to "Open in Data Catalog"

@faustoperez Removed the linking in the selector modal and data layer
card for the collection title and made the font color `base-500`. (color
themes
[here](https://ui.ds.io/latest/?path=/docs/components-theme-provider--colors)).
Let me know if this should change


![Screenshot 2024-02-26 at 4 09 12
PM](https://github.com/NASA-IMPACT/veda-ui/assets/30272083/767478ac-49dc-44c2-8020-a420412f3da7)

![Screenshot 2024-02-26 at 4 09 21
PM](https://github.com/NASA-IMPACT/veda-ui/assets/30272083/35d32d3c-a5fa-4a48-804c-f141a479e6b1)

![Screenshot 2024-02-26 at 4 09 44
PM](https://github.com/NASA-IMPACT/veda-ui/assets/30272083/ee9d27e4-8117-49fe-9a14-09969b72cbe9)
@sandrahoang686 sandrahoang686 mentioned this issue Feb 27, 2024
Merged
@sandrahoang686
Copy link
Collaborator

This is also to be done: #861

@sandrahoang686
Copy link
Collaborator

For task => select modal - update show/hide filters to be optional depending on view

#862 (review) merged

@sandrahoang686 sandrahoang686 mentioned this issue Feb 28, 2024
Merged
@sandrahoang686 sandrahoang686 self-assigned this Feb 28, 2024
sandrahoang686 added a commit that referenced this issue Feb 29, 2024
@sandrahoang686
Update Data Catalog Links for A&E to open in new tab (#863)
81b861f 
This PR updates the data catalog links for A&E to open in a new tab
instead of the exiting current screen.

Closes #861
Addresses #856
sandrahoang686 added a commit that referenced this issue Feb 29, 2024
@sandrahoang686
Add analysis metrics menu to chart (#860)
e6e3cf2 
This PR adds the analysis metrics menu back to each layer list item in
the explorations page.

Ticket [here](#856)
Design
[here](#856 (comment))

Question for @faustoperez related to icon button location. I moved the
button closer to the right-aligned because of the overlapping arrows.
Please let me know what you think. I discuss this more in the demo video
if you can take a look. Thanks!

Demo vid:
https://www.loom.com/share/56d013aade7945fdb40bff8cd2f3dc56
@j08lue j08lue closed this as completed Feb 29, 2024
@sandrahoang686 sandrahoang686 mentioned this issue Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faustoperez faustoperez

@sandrahoang686 sandrahoang686

Labels
None yet
Projects
None yet
Milestone
E&A Revision 3
Development

No branches or pull requests
3 participants
@j08lue @faustoperez @sandrahoang686