Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Connect E&A flow with Data Layer Selection in NextJs Instance and state persists #1220

Closed
sandrahoang686 opened this issue Oct 28, 2024 · 1 comment
Closed

[Refactor] Connect E&A flow with Data Layer Selection in NextJs Instance and state persists #1220

sandrahoang686 opened this issue Oct 28, 2024 · 1 comment
Assignees
@hanbyul-here
Labels
veda v2 VEDA Refactor Epic Work

Comments

@sandrahoang686
Copy link
Collaborator

sandrahoang686 commented Oct 28, 2024 •
edited by hanbyul-here
Loading

There are a few bugs/improvements that we still need to tackle to make exportable E&A page work.
The identified items so far are:

  • MapboxDraw not added to the map yet when its method is called
  • Date value that gets fed to atom is not valid
  • TimelineDatasetAtom still depends on veda faux module datasets
@sandrahoang686 sandrahoang686 added the veda v2 VEDA Refactor Epic Work label Oct 28, 2024
@sandrahoang686 sandrahoang686 changed the title [Refactor] Connect E&A flow with Data Layer Selection in NextJs Instance [Refactor] Connect E&A flow with Data Layer Selection in NextJs Instance and state persists Oct 29, 2024
@hanbyul-here hanbyul-here mentioned this issue Oct 30, 2024
Merged
@hanbyul-here hanbyul-here self-assigned this Oct 31, 2024
sandrahoang686 added a commit that referenced this issue Nov 6, 2024
@sandrahoang686
Various fixes for E&A (#1229)
7771378 
**Related Ticket:** #1220

### Description of Changes
This PR is WIP, opening in case it helps anybody. (That says, please
don't spend time reviewing the changes in this PR yet, but it will be
really helpful if you can validate that this branch can run with Next
instance with stability.)

### Notes & Questions About Changes
I've noticed E&A still doesn't run with stability in Next instance. I
traced down all the possible errors that I can spot. That includes
#### Fixed in this PR
- export useAtom hook for timelinedataset (to remove the possibility of
more than one jotai instances)
- LinkProperties problem 
- MapboxDraw not added to the map yet when its method is called
- Date value that gets fed to atom is not valid - this was because our
polyfill for Array.last was not getting exported

#### Not fixed in this PR yet

- TimelineDatasetAtom still depends on veda faux module datasets 

I put temporary work-arounds for unsolved problems to validate that
those are the errors that can interrupt Next instance.

### Validate & Test
Please test this branch with `test-branch` Next branch :
https://github.com/developmentseed/next-veda-ui/tree/test-branch - It
will still lack of some functionalities, but hopefully the e&a page
doesn't return abrupt errors anymore.
@hanbyul-here
Copy link
Collaborator

We separate out one last remaining issue : #1238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanbyul-here hanbyul-here

Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hanbyul-here @sandrahoang686