Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable nav for R3 #1071

Open
1 task
hanbyul-here opened this issue Jul 25, 2024 · 0 comments
Open
1 task

Customizable nav for R3 #1071

hanbyul-here opened this issue Jul 25, 2024 · 0 comments
Assignees
@hanbyul-here

Comments

@hanbyul-here
Copy link
Collaborator

hanbyul-here commented Jul 25, 2024 •
edited by aboydnw
Loading

Context

GHG Center wants to make some customizations to the nav bar in their instance. Long term, we know that we want a nav component that can be customized on the instance side, making it easier to maintain and iterate on our core VEDA component. So, it makes sense to allow for the GHG R3 customizations to occur on the instance side. We need to enable that

Acceptance Criteria

  • Any customizations to the nav bar (titles, layout, color, logos, dropdowns, etc) occur on the instance side of the VEDA Dashboard implementation
@hanbyul-here hanbyul-here mentioned this issue Jul 25, 2024
Merged
2 tasks
hanbyul-here added a commit that referenced this issue Aug 8, 2024
@hanbyul-here
Exportable nav (#1072)
76b03c4 
**Related Ticket:** #1071 

### Description of Changes
Exporting nav from UI side so it can be used to override its menu from
GHG side.
The code changes look like a lot, but most of them are just pieces
moving around and making the components accept props.

This change checks the veda.config to see if there are any defined
`navItems` and use it if there is one instead of the default one. There
can be 4 types of nav item, which are `internalLink`, `externalLink`,
`dropdown`, `modal`. The details of each type will be documented.

### Notes & Questions About Changes

The current version does not mark the dropdown item as 'active' when its
child is selected.

### Validation / Testing
_{Update with info on what can be manually validated in the Deploy
Preview link for example "Validate style updates to selection modal do
NOT affect cards"}_

Instance pr: US-GHG-Center/veda-config-ghg#457

- [x] remove test config from veda.config
- [ ] Add documentation : will do it after style polish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanbyul-here hanbyul-here

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hanbyul-here