Skip to content

Commit

Permalink
FIX: update external link in top navigation target (#1145)
Browse files Browse the repository at this point in the history
### Description of Changes
this updates the `nav-menu-item` with external links to have
`target="_bank"` instead of `target="blank"`. There's [a slight
difference in the behavior](https://css-tricks.com/targetblank/).
and other external links have used the underscore.
  • Loading branch information
stephenkilbourn authored Sep 4, 2024
2 parents 78c79e1 + 5efdc52 commit 4968775
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export default function NavMenuItem({ item, alignment, onClick }: {item: NavItem
<li key={`${title}-nav-item`}>
<GlobalMenuLink
as='a'
target='blank'
target='_blank'
rel='noopener'
onClick={onClick}
href={(rest as ExternalNavLink).href}
Expand Down

0 comments on commit 4968775

Please sign in to comment.