Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in a few data & story mdx files #388

Merged
merged 2 commits into from
May 3, 2024

Conversation

dzole0311
Copy link
Collaborator

@dzole0311 dzole0311 commented May 3, 2024

We have some broken links in a few .mdx files that point to an older /datasets route instead of the new /data-catalog. I additionally fixed the ones that pointed to https://www.earthdata.nasa.gov/dashboard/eis/datasets so that now they point to https://www.earthdata.nasa.gov/dashboard/data-catalog as I think at some point the eis routing part has been removed (@j08lue @sandrahoang686 please confirm)?

Copy link

netlify bot commented May 3, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit cc4be99
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/6634dcad5348220008063081
😎 Deploy Preview https://deploy-preview-388--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dzole0311 dzole0311 requested review from j08lue and sandrahoang686 May 3, 2024 10:28
@dzole0311 dzole0311 linked an issue May 3, 2024 that may be closed by this pull request
1 task
@@ -368,7 +368,7 @@ The output variables available on VEDA include evapotranspiration (ET), gross pr
<Block>
<Prose>
## Explore the Data
The global reanalysis is a large dataset with nearly two decades of daily output. Here we show a comparison of two dates for a single variable. We encourage users to <Link to='/datasets/global-reanalysis-da/explore'>Explore the Data></Link> to look at different dates and to compare variables.
The global reanalysis is a large dataset with nearly two decades of daily output. Here we show a comparison of two dates for a single variable. We encourage users to <Link to='/data-catalog/global-reanalysis-da/explore'>Explore the Data></Link> to look at different dates and to compare variables.
Copy link
Collaborator

@sandrahoang686 sandrahoang686 May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ : There is a weird carrot after the word Data, dont think its supposed to be there. Maybe if we can move that too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for spotting that, removed! Looks to me like the carrot was supposed to "mimic" a link

Copy link
Collaborator

@sandrahoang686 sandrahoang686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those links look like they work now. Thank you for going through the code and cleaning 😌 🙌🏼 . Teeny comment but ✅

@sandrahoang686 sandrahoang686 self-requested a review May 3, 2024 12:40
@dzole0311 dzole0311 merged commit 6c4486b into develop May 3, 2024
6 checks passed
@dzole0311 dzole0311 deleted the fix-broken-data-catalog-links branch May 3, 2024 12:56
@@ -90,7 +90,7 @@ layers:

* [EIS Freshwater](https://freshwater.eis.smce.nasa.gov/)
* [Land Information System](https://lis.gsfc.nasa.gov/)
* [Global Reanalysis Dataset page](https://www.earthdata.nasa.gov/dashboard/eis/datasets)
* [Global Reanalysis Dataset page](https://www.earthdata.nasa.gov/dashboard/data-catalog)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 : Oops, if this is supposed to be eis datasets, then it might be https://www.earthdata.nasa.gov/dashboard/data-catalog?taxonomy=%7B%22Topics%22%3A%22eis%22%7D instead? @j08lue can you confirm?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yes, it is correct to replace this with a taxonomy filter. 💯

@@ -77,7 +77,7 @@ taxonomy:
<Block>
<Prose>
## Comparing the trends in water and carbon cycles
We applied a seasonal and trend decomposition algorithm to get the trend estimates for terrestrial water storage and gross primary production. The method can better help to deal with [nonstationarities](https://github.com/Earth-Information-System/sea-level-and-coastal-risk/blob/main/AMS_2023_Wanshu_Nie_for_VEDA_Discovery.pdf) and seasonal shifts and provide a more robust estimate of trends. These trend data sets are also provided in the [VEDA dataset page](https://www.earthdata.nasa.gov/dashboard/eis/datasets).
We applied a seasonal and trend decomposition algorithm to get the trend estimates for terrestrial water storage and gross primary production. The method can better help to deal with [nonstationarities](https://github.com/Earth-Information-System/sea-level-and-coastal-risk/blob/main/AMS_2023_Wanshu_Nie_for_VEDA_Discovery.pdf) and seasonal shifts and provide a more robust estimate of trends. These trend data sets are also provided in the [VEDA dataset page](https://www.earthdata.nasa.gov/dashboard/data-catalog).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, is it supposed to be this https://www.earthdata.nasa.gov/dashboard/data-catalog?taxonomy=%7B%22Topics%22%3A%22eis%22%7D for eis datasets?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace broken links to /datasets with /data-catalog
3 participants