Add placement param to figures #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfdsilva
requested changes
Jul 31, 2020
There was a problem hiding this comment.
The image is still not respecting the positioning.
To test:
- Add some text after the image (http://localhost:3006/atbdsedit/1/drafts/1/algorithm_description). Even if the image does not render it is there.
- When the PDF is rendered the image does not show between the elements and is moved to the next page.
|
I think that is the effect of the |
danielfdsilva
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LaTeX floats objects like images because they should not be broken over pages. This means that by default it will decide where to put an image in the layout. I have added the
hparameter to the figures in the latex markup which indicatesplace approximately heresee docs. This should address #257, this is somewhat tough to test because of image upload problems.I think this might be sufficient? TeX often requires tends to require additional commands inserted into the template to tune a layout to what the author wants, so it is hard to allow complete control from the front end without creating a 1:1 correspondence with LaTeX commands.