Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update argument type #8

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Update argument type #8

merged 1 commit into from
Feb 15, 2023

Conversation

camargo
Copy link
Member

@camargo camargo commented Feb 14, 2023

Closes #6

@camargo camargo added the refactor A code change that neither fixes a bug nor adds a feature label Feb 14, 2023
@camargo camargo self-assigned this Feb 14, 2023
@camargo camargo force-pushed the refactor/arg-format branch 2 times, most recently from ad0f209 to 7046d74 Compare February 14, 2023 22:49
@camargo
Update argument type
79577e3 
* Update tests
@camargo camargo force-pushed the refactor/arg-format branch from 7046d74 to 79577e3 Compare February 14, 2023 22:51
cohansen
cohansen reviewed Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@cohansen cohansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the version and run npm i :)

Going to run the tests here shortly.

goetzrrGit
goetzrrGit approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@goetzrrGit goetzrrGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick spot check and things look good Maybe wait for @cohansen to run the test before merging.

@camargo
Copy link
Member Author

camargo commented Feb 14, 2023

Just for reference we also run both sets of tests (JavaScript and Python) in CI here: https://github.com/NASA-AMMOS/seq-json-schema/actions/runs/4178798175/jobs/7238017445

@camargo camargo merged commit b56782b into develop Feb 15, 2023
@camargo camargo deleted the refactor/arg-format branch February 15, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetzrrGit goetzrrGit goetzrrGit approved these changes

@cohansen cohansen cohansen approved these changes

Assignees

@camargo camargo

Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make argument format more explicit
3 participants
@camargo @cohansen @goetzrrGit