-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates the naming of the EVR View Inspect tab "EVR View Levels Confi… #56
Updates the naming of the EVR View Inspect tab "EVR View Levels Confi… #56
Conversation
…guration" to clarify that it's the EVR Level Style that is being applied, not the EVR level in the view.
…thewater/openmct-mcws into evr-level-style-tab-rename
Since there is already a style tab, I updated it instead to 'Color' as that's more in line with what we're technically doing here. The color options come from config.js and truly are individual colors as opposed to styles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great change. Can you shorten it to Level Color
or just Color
? There is going to be more tab name changes coming soon and tabs like EVR View Configuration
will be shortened to just Config
.
Sure, I'll update it next week. |
Updated to 'Level Color' for shorter naming convention required by @davetsay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @mudinthewater
Closes #67