Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the naming of the EVR View Inspect tab "EVR View Levels Confi… #56

Merged
merged 10 commits into from
Oct 3, 2023

Conversation

mudinthewater
Copy link
Contributor

@mudinthewater mudinthewater commented Jun 18, 2023

Closes #67

Peter Di Pasquale and others added 2 commits June 18, 2023 11:46
…guration" to clarify that it's the EVR Level Style that is being applied, not the EVR level in the view.
@mudinthewater mudinthewater reopened this Jun 18, 2023
@mudinthewater
Copy link
Contributor Author

Since there is already a style tab, I updated it instead to 'Color' as that's more in line with what we're technically doing here. The color options come from config.js and truly are individual colors as opposed to styles.

Copy link
Collaborator

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change. Can you shorten it to Level Color or just Color? There is going to be more tab name changes coming soon and tabs like EVR View Configuration will be shortened to just Config.

@mudinthewater
Copy link
Contributor Author

Sure, I'll update it next week.

@mudinthewater mudinthewater requested a review from davetsay August 3, 2023 15:31
Copy link
Collaborator

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @mudinthewater

@davetsay davetsay merged commit 0508e28 into NASA-AMMOS:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVR Level Configuration tab should be renamed for clarity
2 participants